Skip to content
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.

fix(input.go): delete answer after validate failure #351

Closed
wants to merge 1 commit into from
Closed

fix(input.go): delete answer after validate failure #351

wants to merge 1 commit into from

Conversation

zitn
Copy link

@zitn zitn commented Apr 16, 2021

Closes #350

@AlecAivazis
Copy link
Owner

@zigitn - i fixed the issue preventing the CI pipeline from executing. Mind rebasing onto master so we can get this in?

@zitn
Copy link
Author

zitn commented Apr 22, 2021

Of course, do I need to submit a new pr?

@AlecAivazis
Copy link
Owner

You should be able to get away with just force-pushing over your existing branch

@AlecAivazis
Copy link
Owner

AlecAivazis commented Apr 24, 2021

Thanks for doing that @zigitn! Do you mind adding a test that verifies this behavior?

@cben
Copy link
Contributor

cben commented May 9, 2021

@AlecAivazis I didn't find existing tests for WithValidator that actually test the input.go logic. Do you have advice how/where to test this?

@AlecAivazis
Copy link
Owner

@cben - thanks for picking this up. I think the Ask tests are a good example to copy

@cben
Copy link
Contributor

cben commented May 11, 2021

Turns out the whole TestAsk test has been disabled in https://github.com/AlecAivazis/survey/pull/216/files#diff-3a029c8ea50304c9dc5637560df2375bc28f1620d72744a13f4d3c152bb16a4aR120 and doesn't run.
I'm working on separate PR to re-enable them (or most of them) => #354.
Meanwhile I noticed that this PR breaks one of the existing tests; didn't check yet if a real bug, but I suggest holding on merging this until we have the tests back.

@AlecAivazis
Copy link
Owner

Going to close this as its gone a bit stale

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

after validate failure, answer value not output or clean
3 participants