Skip to content
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.

Fixes #334: Make sure the cursor goes back to the begining of the lin… #335

Merged
merged 1 commit into from Apr 22, 2021

Conversation

PierreBtz
Copy link
Contributor

…e when jumping lines.

See #334 for the details. This code is doing the same as what Windows does.

There is something odd in the the n parameter passed to both methods is never used as we use 1. The Windows code does not do this and the previous code (changed in #309) did not do this either. I have a feeling it should be c.Down(n) and c.Up(n) but I did not analyze this library enough to be confident.

@AlecAivazis
Copy link
Owner

@coryb @mislav any chance you could test this out? I'm always nervous being the only set of eyes on something touching cursor interactions

@nhatthm
Copy link

nhatthm commented Apr 20, 2021

Thanks @PierreBtz for the fix 🙌

I could reproduce the issue on my Mac (10.14.6 with iTerm2 3.4.5) and with hinshun/vt10x (see my test). It's fixed after applying your changes 👍

However, I don't have experience in Cursor and the test was in the emulator so I can't validate your code :D

Updated: I tested on Mac manually and it fixes the issue too!

@AlecAivazis
Copy link
Owner

@PierreBtz - i fixed the issue preventing the CI pipeline from executing. Mind rebasing onto master so we can get this in?

@AlecAivazis
Copy link
Owner

And thanks @nhatthm for verifying this fix!

@PierreBtz
Copy link
Contributor Author

@AlecAivazis I rebased, looks like the build is passing now, thanks for fixing it, and thanks for your work on this project :)

@AlecAivazis AlecAivazis merged commit 69b2cbe into AlecAivazis:master Apr 22, 2021
@PierreBtz PierreBtz deleted the pbeitz/dev branch September 8, 2021 08:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants