Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Rails 6.1 #2047

Merged
merged 12 commits into from
Sep 12, 2021
Merged

Allow Rails 6.1 #2047

merged 12 commits into from
Sep 12, 2021

Commits on Sep 12, 2021

  1. Allow Rails 6.1 and make it the default

    @robinboening @tvdeyen
    robinboening authored and tvdeyen committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    af13563 View commit details
    Browse the repository at this point in the history

  2. Fix tinymce feature spec 

    This feature spec failed with Rails 6.1 as it was defaulting to example.com instead of 127.0.0.1.

Setting `asset_host` inside the test is more explicit as it was before and reflects what an actual app does.
    @robinboening @tvdeyen
    robinboening authored and tvdeyen committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    7d6bc25 View commit details
    Browse the repository at this point in the history

  3. Fix page specs failing with Rails 6.1

    @robinboening @tvdeyen
    robinboening authored and tvdeyen committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    25ffa9e View commit details
    Browse the repository at this point in the history

  4. Update dummy app to Rails 6.1

    @tvdeyen
    tvdeyen committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    76a1f9b View commit details
    Browse the repository at this point in the history

  5. Include helpers in picture ingredient editor spec 

    Those helpers are not included by Rails anymore.
Since a view spec is a unit test we need to stub/include
everything we need on ourselves.
    @tvdeyen
    tvdeyen committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    89f124f View commit details
    Browse the repository at this point in the history

  6. Fix element spec for Rails 6.1 

    First create elements with the page_version (the direct relation)
and not a page (an indirect join via the page_version).

Also reload element in nested_elements spec.
Somehow this is now necessary in Rails 6.1.
    @robinboening @tvdeyen
    robinboening authored and tvdeyen committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    4a080c6 View commit details
    Browse the repository at this point in the history

  7. Update dummy app schema to Rails 6.1

    @tvdeyen
    tvdeyen committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    eb1b324 View commit details
    Browse the repository at this point in the history

  8. Stub configuration method in pages helper spec 

    Instead of globally including a module into the tet controller
we stub the one method the spec uses
    @tvdeyen
    tvdeyen committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    abc5a05 View commit details
    Browse the repository at this point in the history

  9. Remove configuration methods include in url helper spec 

    It is not necessary. The specs pass without globally including
a module in the test controller
    @tvdeyen
    tvdeyen committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    3714635 View commit details
    Browse the repository at this point in the history

  10. Expect page_version save to change page updated_at 

    Instead of expecting that rails calls a method on the receiver
we expect that the updated_at time has changed.
    @tvdeyen
    tvdeyen committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    a09ff32 View commit details
    Browse the repository at this point in the history

  11. Only set db host if variable is specified 

    Not everybody is using a db running on host but on a socket instead.
    @tvdeyen
    tvdeyen committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    eda438a View commit details
    Browse the repository at this point in the history

  12. Use latest Rubies on CI

    @tvdeyen
    tvdeyen committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    ac63b67 View commit details
    Browse the repository at this point in the history