fix: Use contextmanager for process creation in tests #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure that the responsibility for stopping running processes does not leak to call sites.
aiven-anton
force-pushed
the
fix/use-context-managers-in-tests
branch
from
2544ac2
to
f43841e
Compare
Deploying with
|
| Latest commit: |
f43841e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://44a785ce.karapace.pages.dev |
| Branch Preview URL: | https://fix-use-context-managers-in-.karapace.pages.dev |
|
There have been a few consecutive runs with timeouts now. I wonder if cleaning up the processes is the cause of the increased execution time. This needs more investigation, so changed to draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
Use
@contextmanagerfor handling ZooKeeper and Kafka test processes.Why this way
This makes sure that the responsibility for stopping running processes does not leak to call sites, but is rather handled in the same place as the processes are spawned. This was found when upgrading pylint to latest version, which introduces a lint error for these cases.