Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bump pre-commit hooks to fix isort issue #531

Merged
merged 1 commit into from
Feb 1, 2023

Commits on Jan 31, 2023

  1. fix: Bump pre-commit hooks to fix isort issue

    CI is broken on main due to this isort issue, the root cause lies in an
    underlying incompatible change in Poetry. The new version of isort has
    dropped support for Python 3.7 so we bump CI to run on 3.11 instead (3.7
    is EOL later this year anyway).
    
    PyCQA/isort#2083
    
    With the upgrade to flake8 6, we ran into an issue with comments in the
    configuration file. Those comments are moved to their own lines above
    the config instead, see issue below.
    
    PyCQA/flake8#1756
    
    Because of installation issues in the lint step, installation is altered
    to only installed pre-commit which handles its own dependencies anyway.
    Pylint is normalized to be installed just like the other pre-commit
    hooks, the dependency on the environment is removed.
    aiven-anton committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    d3a104b View commit details
    Browse the repository at this point in the history