allow use before define

[turadg]

no ticket

Description

The no-use-before-define rule was motivated by when variables could hoist up in surprising ways. We always use let and const which have the Temporal Dead Zone that will throw an error if used before declaration.

So we don't need this rule anymore and it's mostly noise.

Security Considerations

n/a, lint

Scaling Considerations

n/a, lint

Documentation Considerations

reduces need for docs

Testing Considerations

CI

Upgrade Considerations

n/a, lint

[cloudflare-pages]

Deploying agoric-sdk with    Cloudflare Pages

Latest commit:	31d3f7d
Status:	✅  Deploy successful!
Preview URL:	https://4471299f.agoric-sdk.pages.dev
Branch Preview URL:	https://ta-allow-use-before-define.agoric-sdk.pages.dev

View logs

[dckc]

... We always use let and const

We haven't removed all use of function. It looks like hundreds of them remain.

https://github.com/Agoric/agoric-sdk/blob/master/packages/SwingSet/src/controller/controller.js
https://github.com/Agoric/agoric-sdk/blob/master/packages/SwingSet/src/kernel/kernel.js

agoric-sdk/packages/vats/src/crc.js

Line 16 in e4a6095

function convert(data) {

etc.

I don't think we even have a lint rule to avoid it.

[turadg]

We haven't removed all use of function. It looks like hundreds of them remain.

Good point. But as you also point out this rule doesn't pertain to those.

Any reason to keep this rule?

[dckc]

We haven't removed all use of function. It looks like hundreds of them remain.

Good point. But as you also point out this rule doesn't pertain to those.

use-before-defined does apply to functions, IIUC.

What I meant was: we don't have a rule to say "use const instead of function".

[erights]

An unrelated drive-by? (no objection. Just making sure I understand.)

[turadg]

yep, c4d7f8d, to improve the tred graph

[erights]

An unrelated drive-by? (no objection. Just making sure I understand.)