8273 remove custom Ava glob #9352
Open
+0
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
f678160
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://885e11ab.agoric-sdk.pages.dev |
| Branch Preview URL: | https://8273-expand-glob.agoric-sdk.pages.dev |
kriskowal
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #8273
Description
#8653 adopted the new glob but left the old one so any in-flight PRs with new tests wouldn't have them ignored.
It's been a month so any should be migrated by now. This removes the old glob.
It doesn't remove the
"files"option entirely, because the default glob is everything undertestand we have files there that aren't tests. Ava warns they're not tests and and eslint errors when tests import from them. We could go fully to the default glob by using an underscore prefixes on files intestthat aren't tests. I don't think we need to do that. This change already meets the goal of matching the DX of Ava in other repos. (Test filenames are indicated by a.test.jssuffix)Security Considerations
n/a
Scaling Considerations
n/a
Documentation Considerations
reduces need to document
Testing Considerations
no older test files in master (
find packages -name 'test-*' |grep 'test/')Upgrade Considerations
n/a