deps(go): use cosmos/ibc-go v6.3.0 #9341
Conversation
Deploying agoric-sdk with
|
| Latest commit: |
b2a90dd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a6dbfe3b.agoric-sdk.pages.dev |
| Branch Preview URL: | https://9205-update-ibc-go.agoric-sdk.pages.dev |
| @@ -192,9 +192,6 @@ replace ( | |||
| // Pick up an IAVL race fix. | |||
| github.com/cosmos/iavl => github.com/cosmos/iavl v0.19.7 | |||
|
|
|||
| // Async version negotiation | |||
| github.com/cosmos/ibc-go/v6 => github.com/agoric-labs/ibc-go/v6 v6.2.1-alpha.agoric.3 | |||
There was a problem hiding this comment.
@michaelfig should confirm, but looking at the diff of v6.2.1-alpha.agoric.3 from upstream v6.2.1, I don't think we can move away from our fork. And there are hopefully tests in agoric-sdk that will fail if we try.
There was a problem hiding this comment.
I don't think we can move away from our fork. And there are hopefully tests in agoric-sdk that will fail if we try.
@LuqiPan's changes in this PR remove the async version negotiation feature detection between our ibc-go fork and agoric-sdk, which allows the tests to pass again while preventing agoric-sdk from using the AsyncVersion code.
In a meeting some time ago, we had agreed not to use that semi-automatic feature detection, and instead would document in the interchain stack upgrade runbook the conditions under which we could set AsyncVersions = true, namely by performing some investigation into the ibc-go implementation we rely on before landing PRs like this one.
There was a problem hiding this comment.
Blocking until the interchain stack upgrade runbook describes the work needed to upgrade AsyncVersions. I'd be happy to help you document this, @LuqiPan.
|
Created #9358 as reference issue, I am updating this PR and interchain stack upgrade runbook to reference this issue. |
|
Updated this PR and https://github.com/Agoric/agoric-sdk/wiki/Upgrading-the-Interchain-Stack (at the bottom) with #9358, should be ready for another look |
|
Moved back to code complete since bot should not have moved this to "done-mn validated" |
closes: #9205
refs: #9205
Description
This PR updates ibc-go in response to GHSA-j496-crgh-34mx
TODO
Security Considerations
This PR addresses GHSA-j496-crgh-34mx
Scaling Considerations
N/A
Documentation Considerations
N/A
Testing Considerations
Relying on our CI/CD to verify things as this is a simple dependency version bump
Upgrade Considerations
N/A