refactor(async-flow): simplify with zonified vow #9336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
force-pushed
the
markm-zonify-vowTools
branch
from
ddf34ae
to
3f405ee
Compare
Deploying agoric-sdk with
|
| Latest commit: |
2d32d1e
|
| Status: | ⚡️ Build in progress... |
erights
force-pushed
the
markm-zonify-vowTools
branch
from
3f405ee
to
7b94edd
Compare
erights
force-pushed
the
markm-async-flow
branch
2 times, most recently
from
596304e
to
4cb7ed6
Compare
erights
force-pushed
the
markm-zonify-vowTools
branch
2 times, most recently
from
f40cf7e
to
a0198f0
Compare
erights
force-pushed
the
markm-zonify-vowTools
branch
from
a0198f0
to
055c780
Compare
erights
added a commit
that referenced
this pull request
May 16, 2024
Staged on #9097 closes: #XXXX refs: #9231 #9321 #9329 #9097 ## Description Now that `watchPromise` is abstracted over zones and vows make use of that, we can simplify the test cases a lot. Should be a pure refactor with no externally observable effect. ### Security Considerations none ### Scaling Considerations none ### Documentation Considerations none ### Testing Considerations tests simpler. Otherwise, none ### Upgrade Considerations none
erights
added
the
asyncFlow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staged on #9097
closes: #XXXX
refs: #9231 #9321 #9329 #9097
Description
Now that
watchPromiseis abstracted over zones and vows make use of that, we can simplify the test cases a lot.Should be a pure refactor with no externally observable effect.
Security Considerations
none
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
tests simpler. Otherwise, none
Upgrade Considerations
none