Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE test against some fork of endo #9201

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erights
Copy link
Member

@erights erights commented Apr 5, 2024

#endo-branch: master

closes: #XXXX
refs: #XXXX

Description

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

@erights erights self-assigned this Apr 5, 2024
Copy link
Contributor

mergify bot commented Apr 5, 2024

⚠️ The sha of the head commit of this PR conflicts with #7937. Mergify cannot evaluate rules on this PR. ⚠️

Copy link

cloudflare-pages bot commented May 5, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9e18813
Status: ✅  Deploy successful!
Preview URL: https://a0e69097.agoric-sdk.pages.dev
Branch Preview URL: https://markm-test-w-some-endo-fork.agoric-sdk.pages.dev

View logs

@erights erights force-pushed the markm-test-w-some-endo-fork branch from 5fbdd1b to 2e1471a Compare May 5, 2024 06:00
@erights erights changed the base branch from master to 1488-Endo-Passable May 5, 2024 06:01
@kriskowal
Copy link
Member

Seems to be down to some ts-expect-errrors that can now be removed.

Error: ../vats/src/vat-bank.js(347,5): error TS2578: Unused '@ts-expect-error' directive.
Error: ../vats/src/vat-bank.js(591,7): error TS2578: Unused '@ts-expect-error' directive.

@@ -133,6 +133,8 @@ const initKernelForTest = async (t, bundleData, config, options = {}) => {
};
};

// Gratuitous change so I can create an otherwise identical PR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git commit -m 'Poke CI' --allow-empty creates a no-changes commit that will pump CI.

@erights erights force-pushed the markm-test-w-some-endo-fork branch 2 times, most recently from 1158cab to 575f79d Compare May 6, 2024 21:58
@erights erights force-pushed the markm-test-w-some-endo-fork branch from 575f79d to 08ff8aa Compare May 8, 2024 22:47
@erights erights changed the base branch from 1488-Endo-Passable to master May 8, 2024 22:47
@erights erights force-pushed the markm-test-w-some-endo-fork branch from 08ff8aa to 9e18813 Compare May 9, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
force:integration Force integration tests to run on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants