Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt async version negotiation from ibc-go #9358

Open
LuqiPan opened this issue May 10, 2024 · 0 comments
Open

Adopt async version negotiation from ibc-go #9358

LuqiPan opened this issue May 10, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@LuqiPan
Copy link
Contributor

LuqiPan commented May 10, 2024

What is the Problem Being Solved?

In ibc-go, version negotiation is done synchronously, however, due to the asynchronous nature of Agoric chain, we'd want to do it asynchronously.

This issue has been addressed in IBC specification, but it's not yet implemented in ibc-go.

Once async version negotiation is implemented in ibc-go, we should:

  1. upgrade ibc-go in agoric-sdk to the latest version that contains this feature
  2. audit https://github.com/Agoric/agoric-sdk/blob/master/golang/cosmos/x/vibc/types/ibc_module.go file to make sure it still matches up with ibc-go's implementation of async version negotiation

Description of the Design

In https://github.com/Agoric/agoric-sdk/blob/master/golang/cosmos/x/vibc/types/ibc_module.go, const AsyncVersions is permanently set to false, once async version negotiation is implemented in ibc-go, we should revisit this const and all the places that are using this const to determine if our code matches up with ibc-go's implementation of async version negotiation.

Security Considerations

N/A

Scaling Considerations

N/A

Test Plan

N/A

Upgrade Considerations

N/A

@LuqiPan LuqiPan added the enhancement New feature or request label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant