Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Address): only emit the Address form data for valid schema fields #2596

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

longyulongyu
Copy link
Contributor

Summary

getAddressSchemaForCountryFlat returns the defined schema fields (for a specific country or default one).
When emitting the Address form data, we should filter out fields that are not in the specified schema.

Tested scenarios

Add unit tests.

@longyulongyu longyulongyu self-assigned this Mar 11, 2024
Copy link

changeset-bot bot commented Mar 11, 2024

🦋 Changeset detected

Latest commit: 949eeb1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@adyen/adyen-web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 11, 2024

Size Change: +12.2 kB (+1%)

Total Size: 1.14 MB

Filename Size Change
packages/lib/dist/adyen.js 302 kB +3.29 kB (+1%)
packages/lib/dist/cjs/index.js 262 kB +3.09 kB (+1%)
packages/lib/dist/es.modern/index.js 125 kB +2.75 kB (+2%)
packages/lib/dist/es/index.js 146 kB +3.09 kB (+2%)
ℹ️ View Unchanged
Filename Size
packages/lib/dist/es.modern/ar.js 6.95 kB
packages/lib/dist/es.modern/cs-CZ.js 6.19 kB
packages/lib/dist/es.modern/da-DK.js 5.62 kB
packages/lib/dist/es.modern/de-DE.js 6.09 kB
packages/lib/dist/es.modern/el-GR.js 7.91 kB
packages/lib/dist/es.modern/es-ES.js 5.73 kB
packages/lib/dist/es.modern/fi-FI.js 5.73 kB
packages/lib/dist/es.modern/fr-FR.js 5.96 kB
packages/lib/dist/es.modern/hr-HR.js 5.99 kB
packages/lib/dist/es.modern/hu-HU.js 6.27 kB
packages/lib/dist/es.modern/it-IT.js 5.81 kB
packages/lib/dist/es.modern/ja-JP.js 6.69 kB
packages/lib/dist/es.modern/ko-KR.js 6.32 kB
packages/lib/dist/es.modern/nl-NL.js 5.76 kB
packages/lib/dist/es.modern/no-NO.js 5.58 kB
packages/lib/dist/es.modern/pl-PL.js 6.27 kB
packages/lib/dist/es.modern/pt-BR.js 5.78 kB
packages/lib/dist/es.modern/pt-PT.js 5.91 kB
packages/lib/dist/es.modern/ro-RO.js 6.05 kB
packages/lib/dist/es.modern/ru-RU.js 7.39 kB
packages/lib/dist/es.modern/sk-SK.js 6.36 kB
packages/lib/dist/es.modern/sl-SI.js 5.91 kB
packages/lib/dist/es.modern/sv-SE.js 5.59 kB
packages/lib/dist/es.modern/zh-CN.js 6.13 kB
packages/lib/dist/es.modern/zh-TW.js 6.22 kB
packages/lib/dist/es/ar.js 6.95 kB
packages/lib/dist/es/cs-CZ.js 6.19 kB
packages/lib/dist/es/da-DK.js 5.62 kB
packages/lib/dist/es/de-DE.js 6.09 kB
packages/lib/dist/es/el-GR.js 7.91 kB
packages/lib/dist/es/es-ES.js 5.73 kB
packages/lib/dist/es/fi-FI.js 5.73 kB
packages/lib/dist/es/fr-FR.js 5.96 kB
packages/lib/dist/es/hr-HR.js 5.99 kB
packages/lib/dist/es/hu-HU.js 6.27 kB
packages/lib/dist/es/it-IT.js 5.81 kB
packages/lib/dist/es/ja-JP.js 6.69 kB
packages/lib/dist/es/ko-KR.js 6.32 kB
packages/lib/dist/es/nl-NL.js 5.76 kB
packages/lib/dist/es/no-NO.js 5.58 kB
packages/lib/dist/es/pl-PL.js 6.27 kB
packages/lib/dist/es/pt-BR.js 5.78 kB
packages/lib/dist/es/pt-PT.js 5.91 kB
packages/lib/dist/es/ro-RO.js 6.05 kB
packages/lib/dist/es/ru-RU.js 7.39 kB
packages/lib/dist/es/sk-SK.js 6.36 kB
packages/lib/dist/es/sl-SI.js 5.91 kB
packages/lib/dist/es/sv-SE.js 5.59 kB
packages/lib/dist/es/zh-CN.js 6.13 kB
packages/lib/dist/es/zh-TW.js 6.22 kB

compressed-size-action

@longyulongyu longyulongyu marked this pull request as ready for review March 20, 2024 09:46
Copy link

sonarcloud bot commented Mar 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants