Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Gitpod support to the playground #2519

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jlengrand
Copy link

Summary

Avoids people having to setup a local environment and instead runs fully in the browser.
This has been requested by our IMs (and some merchants) who are not allowed to install external repositories on their laptop. Using Gitpod (or codespaces) allows them to work without contaminating their local machine. I also allows for a better developer experience, since the yarn process is automated by the .gitpod.yml config.

I had to slightly modify the playground webpack dev server config to go around that issue. Given that we are talking about a playground here, I would argue that this causes not large security threat.
Additional hosts might have to be added if we want to support, say Codespaces.

Happy to answer other questions :).

Tested scenarios

Not relevant

Fixed issue: Internal, DR-520

Avoids people having to setup a local environment and instead runs fully in the browser.
Copy link

changeset-bot bot commented Jan 16, 2024

⚠️ No Changeset found

Latest commit: 33700a9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@m1aw
Copy link
Contributor

m1aw commented Jan 16, 2024

Hey @jlengrand do you know how I can test this? My only concern is the playground being served on a *.gitpod.com address which means we would need to access it via HTTPS otherwise secure fields won't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants