-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/using checkoutanalytics with 3DS2 events base64 and 3DS2 error analytics #2517
Closed
sponglord
wants to merge
158
commits into
main
from
feature/using_checkoutanalytics_with_3DS2_events_base64_and_3DS2_error_analytics
Closed
Feature/using checkoutanalytics with 3DS2 events base64 and 3DS2 error analytics #2517
sponglord
wants to merge
158
commits into
main
from
feature/using_checkoutanalytics_with_3DS2_events_base64_and_3DS2_error_analytics
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…FromAction events)
… a situation we catch)
… for other components to submit analytics
…se64_refactor' into feature/using_checkoutanalytics_with_3DS2_events_base64_and_3DS2_error_analytics # Conflicts: # packages/lib/src/components/ThreeDS2/components/Challenge/PrepareChallenge3DS2.tsx # packages/lib/src/components/ThreeDS2/components/Challenge/types.ts # packages/lib/src/components/ThreeDS2/components/DeviceFingerprint/DoFingerprint3DS2.tsx # packages/lib/src/components/ThreeDS2/components/DeviceFingerprint/PrepareFingerprint3DS2.tsx
* Adding selected info event for issuerList buttons * IssuerList handles analytics for both dropdown & issuerList buttons * Detect and send analytics event when issuerList's dropdown is expanded * Detect and send analytics event (debounced) when issuerList search functionality is used * Moved debounce function to own util file * Fixes for unit tests * Made debounce for search a constant * Adding new unit tests * Removing child comp's submitAnalytics function (since all it does is call super). Removing unused param.
* Detect and send analytics event when qrCode's "Copy" btn is pressed * Fixing unit test fail * Removing child comp's submitAnalytics function (since all it does is call super)
# Conflicts: # packages/lib/src/core/core.ts
…koutAttemptId call failing
# Conflicts: # packages/lib/tsconfig.json
…s how analytics events are created
* Mapping validation error codes to those expected by the endpoint * Fixing unit tests
…ckoutanalytics_with_3DS2_events_and_base64_refactor # Conflicts: # packages/lib/src/components/ApplePay/ApplePay.tsx
…se64_refactor' into feature/using_checkoutanalytics_with_3DS2_events_base64_and_3DS2_error_analytics # Conflicts: # packages/lib/src/components/ThreeDS2/components/utils.test.ts # packages/lib/src/core/Analytics/constants.ts
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WIP: Rethink over how we add analytics to 3DS2
Tested scenarios
Fixed issue: