Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/using checkoutanalytics with 3DS2 events base64 and 3DS2 error analytics #2517

Conversation

sponglord
Copy link
Contributor

Summary

WIP: Rethink over how we add analytics to 3DS2

Tested scenarios

Fixed issue:

…se64_refactor' into feature/using_checkoutanalytics_with_3DS2_events_base64_and_3DS2_error_analytics

# Conflicts:
#	packages/lib/src/components/ThreeDS2/components/Challenge/PrepareChallenge3DS2.tsx
#	packages/lib/src/components/ThreeDS2/components/Challenge/types.ts
#	packages/lib/src/components/ThreeDS2/components/DeviceFingerprint/DoFingerprint3DS2.tsx
#	packages/lib/src/components/ThreeDS2/components/DeviceFingerprint/PrepareFingerprint3DS2.tsx
* Adding selected info event for issuerList buttons

* IssuerList handles analytics for both dropdown & issuerList buttons

* Detect and send analytics event when issuerList's dropdown is expanded

* Detect and send analytics event (debounced) when issuerList search functionality is used

* Moved debounce function to own util file

* Fixes for unit tests

* Made debounce for search a constant

* Adding new unit tests

* Removing child comp's submitAnalytics function (since all it does is call super). Removing unused param.
* Detect and send analytics event when qrCode's "Copy" btn is pressed

* Fixing unit test fail

* Removing child comp's submitAnalytics function (since all it does is call super)
# Conflicts:
#	packages/lib/src/core/core.ts
# Conflicts:
#	packages/lib/tsconfig.json
* Mapping validation error codes to those expected by the endpoint

* Fixing unit tests
…ckoutanalytics_with_3DS2_events_and_base64_refactor

# Conflicts:
#	packages/lib/src/components/ApplePay/ApplePay.tsx
…se64_refactor' into feature/using_checkoutanalytics_with_3DS2_events_base64_and_3DS2_error_analytics

# Conflicts:
#	packages/lib/src/components/ThreeDS2/components/utils.test.ts
#	packages/lib/src/core/Analytics/constants.ts
Base automatically changed from feature/using_checkoutanalytics to main March 11, 2024 11:12
Copy link

sonarcloud bot commented Mar 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
39.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@sponglord sponglord closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant