Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback to distutils #88

Closed
wants to merge 1 commit into from
Closed

Add fallback to distutils #88

wants to merge 1 commit into from

Conversation

cooperlees
Copy link

  • This is so we can build this in an environment that does not yet have
    setuptools
  • Also added Python 3.6 as I built this with 3.6

- This is so we can build this in an environment that does not yet have
  setuptools
- Also added Python 3.6 as I built this with 3.6
@cooperlees
Copy link
Author

Maybe time to also add 3.6 to travis 👌🏻

@adamjstewart
Copy link
Contributor

Mostly a duplicate of #84. One of these two PRs should definitely be merged though.

@jaraco
Copy link
Contributor

jaraco commented Feb 23, 2017

Although this workaround might help alleviate the issue, pip will still always attempt to build sdists with setuptools... so it may not help.

@adamjstewart
Copy link
Contributor

pip will still always attempt to build sdists with setuptools

By attempt, do you mean that it will try to install setuptools from source first? If it uses a wheel, then that wouldn't be a problem. If it doesn't try to build setuptools from source, then wouldn't the fallback of distutils work?

P.S. I know next to nothing about pip and sdists, so I could be very mistaken.

@jaraco
Copy link
Contributor

jaraco commented Feb 23, 2017

I mean it will uncoditionally import setuptools when building any sdist, which it will do in a subprocess of the current Python environment in whatever package state it happens to be in.

@cooperlees
Copy link
Author

Why it may not help pip directly it will help people who run setup.py manually (with other automation) building from sdsts.

@zoofood
Copy link
Contributor

zoofood commented Feb 24, 2017

Thanks Cooper. I'll bring it up to Python 3.6 as well. I used an earlier PR with the same fix. I hope this helps you out.

@zoofood zoofood closed this Feb 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants