Use new objc2 crates #384
Merged
Use new objc2 crates #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DataTriny
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Thanks @madsmtm, looks good!
I think we'll want to integrate this when we update to winit 1.30 though.
|
I see no reason to delay merging this. After all, our objc2 dependencies are already ahead of winit 0.29; this PR doesn't make it any worse. @DataTriny Do you disagree? |
|
Yes @mwcampbell you're right, no need to delay this. Sorry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
icratehas been split into multiple smaller crates, and the feature setup in that has been reworked, which should improve compilation times.