Fix the type signature with circular inheritance #174
+26
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you define a class with the same name as the parent class, sord will generate the type signature with circular inheritance. For example, the code is as follows. ```ruby class ApplicationRecord end module Api class ApplicationRecord < ::ApplicationRecord end end ``` This commit adds a name separator when needed and fixes the type signature so that it is not circular.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you define a class with the same name as the parent class, sord will generate the type signature with circular inheritance.
For example, the code is as follows.
This commit adds a name separator when needed and fixes the type signature so that it is not circular.