Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clippy: clippy::unnecessary_fallible_conversions #188

Merged
merged 1 commit into from Jan 8, 2024
Merged

Clippy: clippy::unnecessary_fallible_conversions #188

merged 1 commit into from Jan 8, 2024

Conversation

commial
Copy link
Contributor

@commial commial commented Jan 8, 2024

No description provided.

@commial commial added the refactoring Code refactoring label Jan 8, 2024
@commial commial merged commit 6a5ce37 into master Jan 8, 2024
24 checks passed
@commial commial deleted the fix-clippy branch January 8, 2024 09:10
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024

Benchmark for a6a4f54

Click to view benchmark
Test Base PR %
chunk_size_decompress_mutilfiles_random/Layers(0x0)/1024 551.7±65.57ns 537.3±44.23ns -2.61%
chunk_size_decompress_mutilfiles_random/Layers(0x0)/1048576 42.6±5.16µs 46.7±6.97µs +9.62%
chunk_size_decompress_mutilfiles_random/Layers(0x0)/16777216 697.4±17.26µs 713.7±30.33µs +2.34%
chunk_size_decompress_mutilfiles_random/Layers(0x0)/65536 3.2±0.47µs 3.4±0.31µs +6.25%
chunk_size_decompress_mutilfiles_random/Layers(COMPRESS)/1024 800.6±445.15µs 827.8±459.65µs +3.40%
chunk_size_decompress_mutilfiles_random/Layers(COMPRESS)/1048576 39.9±0.02ms 41.4±0.09ms +3.76%
chunk_size_decompress_mutilfiles_random/Layers(COMPRESS)/16777216 161.9±0.55ms 165.2±0.31ms +2.04%
chunk_size_decompress_mutilfiles_random/Layers(COMPRESS)/65536 6.6±3.71ms 6.8±3.84ms +3.03%
chunk_size_decompress_mutilfiles_random/Layers(ENCRYPT | COMPRESS)/1024 1101.0±611.04µs 1102.0±611.86µs +0.09%
chunk_size_decompress_mutilfiles_random/Layers(ENCRYPT | COMPRESS)/1048576 39.5±0.05ms 40.6±0.09ms +2.78%
chunk_size_decompress_mutilfiles_random/Layers(ENCRYPT | COMPRESS)/16777216 256.2±0.60ms 265.8±0.24ms +3.75%
chunk_size_decompress_mutilfiles_random/Layers(ENCRYPT | COMPRESS)/65536 6.7±3.08ms 6.8±3.15ms +1.49%
chunk_size_decompress_mutilfiles_random/Layers(ENCRYPT)/1024 787.5±174.06µs 817.5±190.79µs +3.81%
chunk_size_decompress_mutilfiles_random/Layers(ENCRYPT)/1048576 7.9±0.20ms 7.9±0.20ms 0.00%
chunk_size_decompress_mutilfiles_random/Layers(ENCRYPT)/16777216 115.3±0.19ms 114.4±0.05ms -0.78%
chunk_size_decompress_mutilfiles_random/Layers(ENCRYPT)/65536 1327.9±19.96µs 1368.1±20.09µs +3.03%
failsafe_multiple_layers_repair/Layers(0x0)/4194304 26.9±0.20ms 27.2±0.23ms +1.12%
failsafe_multiple_layers_repair/Layers(COMPRESS)/4194304 69.3±0.03ms 70.2±0.28ms +1.30%
failsafe_multiple_layers_repair/Layers(ENCRYPT | COMPRESS)/4194304 77.6±0.17ms 78.4±0.57ms +1.03%
failsafe_multiple_layers_repair/Layers(ENCRYPT)/4194304 37.6±0.24ms 38.2±0.52ms +1.60%
reader_multiple_layers_multiple_block_size/Layers(0x0)/1024 87.3±22.10ns 81.6±16.11ns -6.53%
reader_multiple_layers_multiple_block_size/Layers(0x0)/1048576 45.0±2.22µs 43.8±2.89µs -2.67%
reader_multiple_layers_multiple_block_size/Layers(0x0)/16777216 692.7±27.57µs 693.3±15.04µs +0.09%
reader_multiple_layers_multiple_block_size/Layers(0x0)/65536 2.8±0.25µs 2.8±0.19µs 0.00%
reader_multiple_layers_multiple_block_size/Layers(COMPRESS)/1024 3.3±2.61µs 3.3±2.69µs 0.00%
reader_multiple_layers_multiple_block_size/Layers(COMPRESS)/1048576 5.0±2.96ms 5.1±3.08ms +2.00%
reader_multiple_layers_multiple_block_size/Layers(COMPRESS)/16777216 119.6±0.25ms 123.8±0.29ms +3.51%
reader_multiple_layers_multiple_block_size/Layers(COMPRESS)/65536 208.3±167.38µs 216.0±173.89µs +3.70%
reader_multiple_layers_multiple_block_size/Layers(ENCRYPT | COMPRESS)/1024 15.5±1.39µs 15.5±1.37µs 0.00%
reader_multiple_layers_multiple_block_size/Layers(ENCRYPT | COMPRESS)/1048576 15.8±0.03ms 15.8±0.01ms 0.00%
reader_multiple_layers_multiple_block_size/Layers(ENCRYPT | COMPRESS)/16777216 258.1±0.26ms 258.4±0.28ms +0.12%
reader_multiple_layers_multiple_block_size/Layers(ENCRYPT | COMPRESS)/65536 954.1±77.52µs 954.4±77.69µs +0.03%
reader_multiple_layers_multiple_block_size/Layers(ENCRYPT)/1024 6.9±0.21µs 6.9±0.21µs 0.00%
reader_multiple_layers_multiple_block_size/Layers(ENCRYPT)/1048576 7.0±0.20ms 7.0±0.20ms 0.00%
reader_multiple_layers_multiple_block_size/Layers(ENCRYPT)/16777216 114.0±0.13ms 114.3±1.01ms +0.26%
reader_multiple_layers_multiple_block_size/Layers(ENCRYPT)/65536 437.6±13.63µs 438.6±13.36µs +0.23%
reader_multiple_layers_multiple_block_size_multifiles_linear/Layers(0x0)/1024 480.2±14.41ns 486.5±17.25ns +1.31%
reader_multiple_layers_multiple_block_size_multifiles_linear/Layers(0x0)/1048576 45.3±2.68µs 42.4±3.14µs -6.40%
reader_multiple_layers_multiple_block_size_multifiles_linear/Layers(0x0)/16777216 641.2±58.86µs 723.0±38.46µs +12.76%
reader_multiple_layers_multiple_block_size_multifiles_linear/Layers(0x0)/65536 3.5±0.14µs 3.3±0.32µs -5.71%
reader_multiple_layers_multiple_block_size_multifiles_linear/Layers(COMPRESS)/1024 11.2±0.10µs 11.6±0.09µs +3.57%
reader_multiple_layers_multiple_block_size_multifiles_linear/Layers(COMPRESS)/1048576 10.0±0.11ms 10.4±0.11ms +4.00%
reader_multiple_layers_multiple_block_size_multifiles_linear/Layers(COMPRESS)/16777216 159.1±0.37ms 165.2±0.32ms +3.83%
reader_multiple_layers_multiple_block_size_multifiles_linear/Layers(COMPRESS)/65536 628.6±6.26µs 650.4±3.29µs +3.47%
reader_multiple_layers_multiple_block_size_multifiles_linear/Layers(ENCRYPT | COMPRESS)/1024 17.6±0.11µs 22.6±0.45µs +28.41%
reader_multiple_layers_multiple_block_size_multifiles_linear/Layers(ENCRYPT | COMPRESS)/1048576 15.7±0.06ms 16.1±0.01ms +2.55%
reader_multiple_layers_multiple_block_size_multifiles_linear/Layers(ENCRYPT | COMPRESS)/16777216 249.6±0.30ms 256.3±0.39ms +2.68%
reader_multiple_layers_multiple_block_size_multifiles_linear/Layers(ENCRYPT | COMPRESS)/65536 980.0±7.32µs 1001.3±5.66µs +2.17%
reader_multiple_layers_multiple_block_size_multifiles_linear/Layers(ENCRYPT)/1024 8.2±0.08µs 8.5±0.03µs +3.66%
reader_multiple_layers_multiple_block_size_multifiles_linear/Layers(ENCRYPT)/1048576 7.7±0.06ms 8.0±0.02ms +3.90%
reader_multiple_layers_multiple_block_size_multifiles_linear/Layers(ENCRYPT)/16777216 123.4±0.14ms 129.2±0.35ms +4.70%
reader_multiple_layers_multiple_block_size_multifiles_linear/Layers(ENCRYPT)/65536 462.3±8.19µs 484.0±8.22µs +4.69%
writer_multiple_layers_multiple_block_size/Layers(0x0)/1024 3.5±0.05µs 3.5±0.05µs 0.00%
writer_multiple_layers_multiple_block_size/Layers(0x0)/1048576 3.4±0.09ms 3.4±0.32ms 0.00%
writer_multiple_layers_multiple_block_size/Layers(0x0)/16777216 54.1±0.74ms 54.0±0.71ms -0.18%
writer_multiple_layers_multiple_block_size/Layers(0x0)/65536 210.4±6.19µs 210.0±6.17µs -0.19%
writer_multiple_layers_multiple_block_size/Layers(COMPRESS)/1024 6.6±0.47µs 6.1±0.22µs -7.58%
writer_multiple_layers_multiple_block_size/Layers(COMPRESS)/1048576 10.6±0.37ms 10.8±0.33ms +1.89%
writer_multiple_layers_multiple_block_size/Layers(COMPRESS)/16777216 320.5±1.44ms 322.8±0.98ms +0.72%
writer_multiple_layers_multiple_block_size/Layers(COMPRESS)/65536 421.2±31.72µs 426.0±32.03µs +1.14%
writer_multiple_layers_multiple_block_size/Layers(ENCRYPT | COMPRESS)/1024 6.3±0.47µs 6.2±0.44µs -1.59%
writer_multiple_layers_multiple_block_size/Layers(ENCRYPT | COMPRESS)/1048576 11.9±0.56ms 12.1±0.04ms +1.68%
writer_multiple_layers_multiple_block_size/Layers(ENCRYPT | COMPRESS)/16777216 412.9±1.38ms 419.1±1.12ms +1.50%
writer_multiple_layers_multiple_block_size/Layers(ENCRYPT | COMPRESS)/65536 369.4±0.91µs 451.5±4.71µs +22.23%
writer_multiple_layers_multiple_block_size/Layers(ENCRYPT)/1024 11.9±0.03µs 11.7±0.21µs -1.68%
writer_multiple_layers_multiple_block_size/Layers(ENCRYPT)/1048576 11.5±0.05ms 11.2±0.08ms -2.61%
writer_multiple_layers_multiple_block_size/Layers(ENCRYPT)/16777216 183.9±0.55ms 179.7±0.68ms -2.28%
writer_multiple_layers_multiple_block_size/Layers(ENCRYPT)/65536 718.0±3.96µs 701.6±6.46µs -2.28%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactoring Code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@commial