Add a feature "send" to provide an Send ArchiveWriter #122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #120
This PR:
send
for MLA, disabled by default, which makeArchiveWriter<W>
Send
ArchiveWriter
is actuallySend
when the feature is onWhen the feature is on, the
W
type must beSend
.Forcing
Send
on theInnerWriterType
could have been a simpler way. But it also force the user-provided type to be Sent.Indeed, the last layer (
RawLayer
) can't beSend
if its inner type (W
, the user-provided one) is notSend
.The feature mitigates this behavior: it does not require the
W
type to beSend
, unless the user actually needArchiveWriter
to beSend
.This behavior could have been obtain with an
unsafe
statement, but I'm trying to avoid them in MLA.