Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image edit #2278

Merged
merged 5 commits into from
May 16, 2024
Merged

Fix image edit #2278

merged 5 commits into from
May 16, 2024

Conversation

quininez
Copy link
Member

@quininez quininez commented May 14, 2024

Description

  • fix image edit by providing the original image source in the editor
  • add image upload state in the editor

Issues that will be closed

Testing

Checklist

  • I have read the README document
  • I have read the CONTRIBUTING document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • My commit message follows Conventional Commit Guideline

Copy link

cloudflare-pages bot commented May 14, 2024

Deploying akasha-core-framework with  Cloudflare Pages  Cloudflare Pages

Latest commit: ea52e68
Status: ✅  Deploy successful!
Preview URL: https://62f07e0f.akasha-world-framework.pages.dev
Branch Preview URL: https://patch1.akasha-world-framework.pages.dev

View logs

@quininez quininez marked this pull request as ready for review May 16, 2024 11:41
@quininez quininez enabled auto-merge (squash) May 16, 2024 11:47
@themonster2015
Copy link
Contributor

themonster2015 commented May 16, 2024

Screenshot 2024-05-16 at 14 08 03

Hi Vali! I tested it and it seemed there is still a problem with the image editing. I uploaded 4 images, and then proceeded to edit (crop) some of them. The ones that I cropped and saved turned into those tiny rectangles

@quininez
Copy link
Member Author

Ok, I will test it some more, it's hard to debug since on local it doesn't happen

@quininez quininez disabled auto-merge May 16, 2024 12:40
@quininez quininez enabled auto-merge (squash) May 16, 2024 12:54
@quininez quininez merged commit 474c605 into next May 16, 2024
6 checks passed
@quininez quininez deleted the patch1 branch May 16, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants