Add endpoint to get most recently elected boards #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mentioning it here, but also holds for the other PRs (and will include it on mine in the coming days); would be good if we add some tests. I want to rewrite our testing framework in relation to the mocking of core, but in the meantime we should still add tests |
This is the actual endpoint that I needed as for the AC check, and not the one from the previous commit, but we still might want to use that one for something
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stable #599 +/- ##
==========================================
+ Coverage 98.26% 98.31% +0.04%
==========================================
Files 13 13
Lines 288 296 +8
Branches 47 49 +2
==========================================
+ Hits 283 291 +8
Misses 5 5 ☔ View full report in Codecov by Sentry. |
LeonVreling
changed the title
Also changed an endpoint to make it a more logical name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for functioning of frontend#2036