Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set remote dust limit lower bound #294

Merged
merged 1 commit into from Oct 20, 2021
Merged

Conversation

t-bast
Copy link
Member

@t-bast t-bast commented Sep 15, 2021

We are slowly dropping support for non-segwit outputs, as proposed in lightning/bolts#894
We can thus safely allow dust limits all the way down to 354 satoshis.

In very rare cases where dust_limit_satoshis is negotiated to a low value, our peer may generate closing txs that will not correctly relay on the bitcoin network due to dust relay policies.

When that happens, we detect it and force-close instead of completing the mutual close flow.

@t-bast t-bast requested a review from sstone September 15, 2021 09:09
@t-bast t-bast force-pushed the remote-low-dust-limit-threshold branch from c368fdf to 323e264 Compare September 23, 2021 15:46
@t-bast t-bast force-pushed the remote-low-dust-limit-threshold branch from 323e264 to a72f036 Compare October 20, 2021 07:35
sstone
sstone previously approved these changes Oct 20, 2021
Copy link
Member

@sstone sstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs a rebase

We are slowly dropping support for non-segwit outputs, as proposed in
lightning/bolts#894

We can thus safely allow dust limits all the way down to 354 satoshis.

In very rare cases where dust_limit_satoshis is negotiated to a low value,
our peer may generate closing txs that will not correctly relay on the
bitcoin network due to dust relay policies.

When that happens, we detect it and force-close instead of completing the
mutual close flow.
@t-bast t-bast merged commit fc6fab4 into master Oct 20, 2021
@t-bast t-bast deleted the remote-low-dust-limit-threshold branch October 20, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants