Extensible Liquidity Ads #2848
Draft
Extensible Liquidity Ads #2848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
force-pushed
the
liquidity-ads-official
branch
from
f1c6334
to
cb2183e
Compare
t-bast
force-pushed
the
liquidity-ads-official
branch
from
cb2183e
to
1f9048e
Compare
The channel initiator traditionnally pays the commit tx fees, but we may want to override that when providing services to wallet users. We thus split the current `isInitiator` flag into two flags: - `isChannelOpener` - `payCommitTxFees` We always set `payCommitTxFees` to the same value as `isChannelOpener`. Custom feature bits may override that behavior if necessary. Note that backwards compatibity is preserved since our previous `bool8` codec encodes `true` as `0xff` and `false` as `0x00`.
The initiator of `open_channel2`, `tx_init_rbf` and `splice_init` can request funding from the remote node. The non-initiator node will: - let the open-channel-interceptor plugin decide whether to provide liquidity for new channels or not, and how much - always honor liquidity requests on existing channels (RBF and splice) when funding rates have been configured Liquidity ads are included in the `node_announcement` message, which lets buyers compare sellers and connect to sellers that provide rates they are comfortable with. They are also included in the `init` message which allows providing different rates to specific peers. This implements lightning/bolts#1153. We currently use the temporary tlv tag 1339 while we're waiting for feedback on the spec proposal.
t-bast
force-pushed
the
liquidity-ads-official
branch
from
1f9048e
to
80a358b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initiator of
open_channel2,tx_init_rbfandsplice_initcan request funding from the remote node. The non-initiator node will:Liquidity ads are included in the
node_announcementmessage, which lets buyers compare sellers and connect to sellers that provide rates they are comfortable with. They are also included in theinitmessage which allows providing different rates to specific peers.This implements lightning/bolts#1153. We currently use the temporary tlv tag 1339 while we're waiting for
feedback on the spec proposal.
NB: builds on top of #2845 to make e2e testing easier.