Work around fundrawtransaction consolidation
#2807
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't have any control over bitcoind's coin selection: it sometimes ends up creating transactions with a large number of inputs (and thus a high fee), which we want to avoid. We run multiple coin selection attempts in parallel and use the best result to mitigate that. We should monitor how this behaves in practice and revert that change if it doesn't prove to be useful. We should also push for more configuration options on the bitcoind side to get funding results that better match our transaction patterns.
t-bast
force-pushed
the
retry-funding-attempts
branch
from
52b57b6
to
9c49413
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2807 +/- ##
==========================================
+ Coverage 85.85% 85.88% +0.03%
==========================================
Files 216 216
Lines 18188 18203 +15
Branches 780 782 +2
==========================================
+ Hits 15615 15634 +19
+ Misses 2573 2569 -4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have any control over bitcoind's coin selection: it sometimes ends up creating transactions with a large number of inputs (and thus a high fee), which we want to avoid. We run multiple coin selection attempts in parallel and use the best result to mitigate that.
We should monitor how this behaves in practice and revert that change if it doesn't prove to be useful.
We should also push for more configuration options on the bitcoind side to get funding results that better match our transaction patterns.