Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add require_confirmed_inputs to RBF messages #2783

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

t-bast
Copy link
Member

@t-bast t-bast commented Nov 22, 2023

This was missing from the spec, but is more flexible and clearer than inheriting values from the previous attempt. The dual funding specification added this in lightning/bolts@27ffef4

Fixes #2782

@t-bast t-bast force-pushed the rbf-require-confirmed-inputs branch from cb172a0 to a2f49fc Compare November 23, 2023 15:07
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (61f1e1f) 85.85% compared to head (5aa515d) 85.89%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2783      +/-   ##
==========================================
+ Coverage   85.85%   85.89%   +0.04%     
==========================================
  Files         216      216              
  Lines       18188    18201      +13     
  Branches      780      776       -4     
==========================================
+ Hits        15615    15634      +19     
+ Misses       2573     2567       -6     
Files Coverage Δ
...inq/eclair/channel/fsm/ChannelOpenDualFunded.scala 87.03% <100.00%> (+0.55%) ⬆️
...ala/fr/acinq/eclair/wire/protocol/ChannelTlv.scala 100.00% <100.00%> (ø)
.../acinq/eclair/wire/protocol/InteractiveTxTlv.scala 100.00% <ø> (ø)
...q/eclair/wire/protocol/LightningMessageTypes.scala 98.82% <100.00%> (+0.12%) ⬆️

... and 2 files with indirect coverage changes

This was missing from the spec, but is more flexible and clearer than
inheriting values from the previous attempt.

Fixes #2782
@t-bast t-bast force-pushed the rbf-require-confirmed-inputs branch from a2f49fc to 5aa515d Compare January 2, 2024 15:49
@t-bast t-bast marked this pull request as ready for review January 2, 2024 16:11
@t-bast t-bast requested a review from pm47 January 2, 2024 16:11
@t-bast t-bast merged commit 0393cfc into master Feb 21, 2024
1 check passed
@t-bast t-bast deleted the rbf-require-confirmed-inputs branch February 21, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add require_confirmed_inputs to RBF messages
3 participants