Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NodeAddress everywhere instead of InetAddress #2202

Merged
merged 6 commits into from Mar 25, 2022
Merged

Use NodeAddress everywhere instead of InetAddress #2202

merged 6 commits into from Mar 25, 2022

Commits on Mar 15, 2022

  1. no dns resolution on back, connect to tor nodes from front

    @pm47
    pm47 committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    b03d9d1 View commit details
    Browse the repository at this point in the history

  2. use NodeAddress everywhere

    @pm47
    pm47 committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    bc6d694 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2022

  1. fix typo 

    Co-authored-by: Bastien Teinturier <31281497+t-bast@users.noreply.github.com>
    @pm47 @t-bast
    pm47 and t-bast committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    a81390b View commit details
    Browse the repository at this point in the history

  2. upgrade guava and rewrite nodeuri tests 

    There is no reason to use the version of guava targetting android
anymore. Also `HostAndPort` was in beta in our current lib version.

We now use guava's `InetAddresses.toUriString()` to format host string,
instead of manually adding brackets.

Reworked `NodeURI` tests:
- less repetition with one single test and multiple `testCases`
- focus on non-reg (no need to verify what we know we don't support)
    @pm47
    pm47 committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    f3e16ee View commit details
    Browse the repository at this point in the history

  3. fixup! upgrade guava and rewrite nodeuri tests

    @pm47
    pm47 committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    84f7c7a View commit details
    Browse the repository at this point in the history

  4. fixup! upgrade guava and rewrite nodeuri tests

    @pm47
    pm47 committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    ea31ae8 View commit details
    Browse the repository at this point in the history