Bugfix: Implement escape logic. #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GNOME Keyring uses a specific escape logic for non alphanumeric characters in collection names. Due to this, collections with names containing such characters (e.g. whitespace, underscores) cannot be found using this library (string comparison fails). This patch implements the GNOME Keyring escape logic and uses it when searching for the desired collection.
|
@mgelde Could you please add some tests |
|
Is #83 doing something similar? |
mtibben
reviewed
Oct 11, 2021
| } | ||
| } | ||
| return string(output_buffer) | ||
| } |
There was a problem hiding this comment.
Is this algorithm documented somewhere that we can reference? I can't find similar code in https://github.com/GNOME/gnome-keyring
There was a problem hiding this comment.
I realize you merged #83, which works for me. But for future reference: https://github.com/GNOME/gnome-keyring/blob/f24e374/daemon/dbus/gkd-secret-util.c#L111
I did not see any documentation other than the code...
|
Fixed in #83 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GNOME Keyring uses a specific escape logic for non alphanumeric
characters in collection names. Due to this, collections with names
containing such characters (e.g. whitespace, underscores) cannot be
found using this library (string comparison fails).
This patch implements the GNOME Keyring escape logic and uses it when
searching for the desired collection.