Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS API deprecation warnings #107

Open
roman-yerin opened this issue Feb 5, 2022 · 2 comments
Open

MacOS API deprecation warnings #107

roman-yerin opened this issue Feb 5, 2022 · 2 comments

Comments

@roman-yerin
Copy link

github.com/keybase/go-keychain

cgo-gcc-prolog:81:11: warning: 'SecKeychainCreate' is deprecated: first deprecated in macOS 12.0 - Custom keychain management is no longer supported [-Wdeprecated-declarations]
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Security.framework/Headers/SecKeychain.h:301:10: note: 'SecKeychainCreate' has been explicitly marked deprecated here
cgo-gcc-prolog:139:11: warning: 'SecKeychainLock' is deprecated: first deprecated in macOS 12.0 - Custom keychain management is no longer supported [-Wdeprecated-declarations]
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Security.framework/Headers/SecKeychain.h:357:10: note: 'SecKeychainLock' has been explicitly marked deprecated here
cgo-gcc-prolog:159:11: warning: 'SecKeychainOpen' is deprecated: first deprecated in macOS 12.0 - Custom keychain management is no longer supported [-Wdeprecated-declarations]
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Security.framework/Headers/SecKeychain.h:287:10: note: 'SecKeychainOpen' has been explicitly marked deprecated here
cgo-gcc-prolog:183:11: warning: 'SecKeychainUnlock' is deprecated: first deprecated in macOS 12.0 - Custom keychain management is no longer supported [-Wdeprecated-declarations]
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Security.framework/Headers/SecKeychain.h:347:10: note: 'SecKeychainUnlock' has been explicitly marked deprecated here
cgo-gcc-prolog:203:11: warning: 'SecTrustedApplicationCreateFromPath' is deprecated: first deprecated in macOS 10.15 - No longer supported [-Wdeprecated-declarations]
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Security.framework/Headers/SecTrustedApplication.h:59:10: note: 'SecTrustedApplicationCreateFromPath' has been explicitly marked deprecated here

@iamnoah
Copy link

iamnoah commented Apr 20, 2022

This appears to be resolved in v1.2.1 (maybe earlier)

rootulp added a commit to rootulp/celestia-app that referenced this issue Jul 14, 2022
cosmos/keyring hasn't pulled upstream changes from 99designs/keyring yet
and the latest release of 99designs/keyring (1.2.1) appears to contain
a fix for MacOS warnings: 99designs/keyring#107

Links
- https://github.com/cosmos/keyring/tags
- https://github.com/99designs/keyring/releases/tag/v1.2.1

`make test` passes after this change and it looks like other Cosmos
chains don't need this replace:
- https://github.com/osmosis-labs/osmosis/blob/main/go.mod#L274-L285=
- https://github.com/CosmosContracts/juno/blob/main/go.mod#L178-L182=

Does anyone know if it's still necessary? I couldn't find the justification in
celestiaorg#127 which added it.
rootulp added a commit to celestiaorg/celestia-app that referenced this issue Aug 11, 2022
cosmos/keyring hasn't pulled upstream changes from 99designs/keyring yet
and the latest release of 99designs/keyring (1.2.1) appears to contain
a fix for MacOS warnings: 99designs/keyring#107

Links
- https://github.com/cosmos/keyring/tags
- https://github.com/99designs/keyring/releases/tag/v1.2.1

`make test` passes after this change and it looks like other Cosmos
chains don't need this replace:
- https://github.com/osmosis-labs/osmosis/blob/main/go.mod#L274-L285=
- https://github.com/CosmosContracts/juno/blob/main/go.mod#L178-L182=

Does anyone know if it's still necessary? I couldn't find the justification in
#127 which added it.
@marco-m
Copy link

marco-m commented Sep 7, 2022

@roman-yerin if I understand correctly this can be closed as resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants