Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test asserts: reverse expected and actual params #3027

Merged

Conversation

alexandear
Copy link
Contributor

This PR fixes tests. It reverses passed parameters to the assert.Equal according to the signature (actual after expected):

func Equal(t TestingT), expected, actual interface{}, msgAndArgs ...interface{}) bool

Additionally, the PR enables testifylint linter to automatically detect this type of issues.

I have:

  • Added tests covering the bug / feature (see testing)

@coveralls
Copy link

Coverage Status

coverage: 75.124% (-0.04%) from 75.167%
when pulling 36769ca on alexandear:fix/test-assert-expected-actual
into bf4406a on 99designs:master.

@StevenACoffman StevenACoffman merged commit 28405ac into 99designs:master Apr 29, 2024
17 checks passed
@alexandear alexandear deleted the fix/test-assert-expected-actual branch April 29, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants