Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enum values binding v2 #3014

Merged
merged 1 commit into from May 4, 2024

Conversation

nikitacrit
Copy link
Contributor

@nikitacrit nikitacrit commented Apr 21, 2024

Hello @StevenACoffman @Desuuuu! This is continuation of original pr #2982.
Changes:

  • Directive @goMode on enum values replaced with new directive @goEnum
  • Added restrictions for invalid binding settings and indicating errors for the user
  • Added variables support
  • Added inpackage binding support
  • Added recipe in docs

@coveralls
Copy link

Coverage Status

coverage: 75.0% (-0.1%) from 75.124%
when pulling 211b49e on nikitacrit:enum-values-binding-v2
into ecc3f64 on 99designs:master.

@nikitacrit nikitacrit mentioned this pull request Apr 21, 2024
@nikitacrit nikitacrit marked this pull request as ready for review April 21, 2024 17:47
@nikitacrit
Copy link
Contributor Author

@StevenACoffman @Desuuuu ping 😊

@StevenACoffman
Copy link
Collaborator

I'm going to merge this and cut a release, but I consider @goEnum experimental, and I am open to breaking changes to it if the feedback from the community deems it so.

For instance, if an upcoming Go version adds native sum types (or real Enums that aren't iota) then I would expect this to change in a backwards incompatible way.

@StevenACoffman StevenACoffman merged commit f24ae88 into 99designs:master May 4, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants