Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if go.mod exists while init #2432

Merged
merged 7 commits into from Nov 25, 2022

Conversation

soeti
Copy link
Contributor

@soeti soeti commented Nov 19, 2022

If for something reason we miss go.mod and then run "go run github.com/99designs/gqlgen init" we get cascade errors like:

projects/source/go/test/typeparam/issue51836.dir imports
        ./aa: "./aa" is relative, but relative import paths are not supported in module mode
tidy failed: go mod tidy failed: exit status 

This simple check prevent this

@coveralls
Copy link

coveralls commented Nov 19, 2022

Coverage Status

Coverage decreased (-0.2%) to 75.409% when pulling 92b2d8d on soeti:gomod-miss-check into 89e91da on 99designs:master.

Signed-off-by: Steve Coffman <steve@khanacademy.org>
@StevenACoffman StevenACoffman merged commit efb31b5 into 99designs:master Nov 25, 2022
@StevenACoffman
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants