Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs : embedding schema in generated code #2351

Merged
merged 1 commit into from Nov 25, 2022

Conversation

schafle
Copy link
Contributor

@schafle schafle commented Sep 2, 2022

I recently realized that we have been using wrong configuration. Because we don't have schema file and generated code in the same directory embedding schema in the generated code was not possible. I fixed it in our code but also wanted to fix the example code and documentation of gqlgen for federation examples.

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@coveralls
Copy link

coveralls commented Sep 2, 2022

Coverage Status

Coverage increased (+0.08%) to 75.233% when pulling 12e967b on schafle:embed-federation-schema into b66fff1 on 99designs:master.

@StevenACoffman
Copy link
Collaborator

Hey, just a heads up that I haven't forgotten about this, but I've been vacationing, and in the past there's been problems when I reviewed/merged PRs using my phone without trying them out fully. In particular, changing the documentation like this means I want someone (usually me) to go through all the tutorial's steps and verify there's nothing confusing or broken for new users. I reaaaally wish the tutorial was somehow automated to be scraped and ran as an end-to-end test or something, but right now it's not.

I appreciate your contribution, and I'm sorry for the delay. Thanks for your patience!

@StevenACoffman StevenACoffman merged commit e3af445 into 99designs:master Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants