Draft: install-podman: prefix choosing and system reset fixes #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meister1593
changed the title
|
I will leave this mr as draft as i discover more things attached to this as not being too portable |
Meister1593
changed the title
|
Before proceeding, podman issue needs to be figured out/adressed |
|
Thanks a lot @Meister1593 for this work! |
Yeah this is currently pretty much done, but without rundir fixes that are required so that it won't ever interfere with existing containers (and it will, i did find it out), so it's kindof blocked by this: |
|
Interesting, let's keep an eye on that and revisit in the future :) |
89luca89
force-pushed
the
main
branch
9 times, most recently
from
615a4b5
to
c8ed679
Compare
89luca89
force-pushed
the
main
branch
3 times, most recently
from
6c315c5
to
88e2b5a
Compare
89luca89
force-pushed
the
main
branch
2 times, most recently
from
ba8e5e7
to
0c4615b
Compare
89luca89
force-pushed
the
main
branch
2 times, most recently
from
456475a
to
d065c94
Compare
89luca89
force-pushed
the
main
branch
2 times, most recently
from
cca3514
to
551675e
Compare
89luca89
force-pushed
the
main
branch
2 times, most recently
from
956fad1
to
c14e010
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So while i was making my script (shameless plug) that heavily utilized rootless podman functionality, i noticed that something odd happening with system and non system installations of distrobox.
So it took me a while to realize that it was modifying my home folder podman containers and actually resetting them (!).
I changed installation script a bit to utilise correct prefix if it was specified and excluded podman system commands from being ran at all as they are probably hardcoded to home folder and i didn't find a way to specify prefix for it. Not using them anyway doesn't matter for prefixed installation as prefix is already known.