Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update Mocha plugin and drop ESLint 6 support #95

Merged
merged 1 commit into from Jun 11, 2020

Conversation

AdamVig
Copy link
Contributor

@AdamVig AdamVig commented Jun 11, 2020

Commits

  • feat: update Mocha plugin and drop ESLint 6 support
    BREAKING CHANGE:
    eslint-plugin-mocha no longer supports ESLint versions lower than
    7.0.0, so this configuration now requires a peer dependency of ESLint
    ^7.2.0.

BREAKING CHANGE:
eslint-plugin-mocha no longer supports ESLint versions lower than
7.0.0, so this configuration now requires a peer dependency of ESLint
^7.2.0.
@AdamVig AdamVig self-assigned this Jun 11, 2020
@AdamVig AdamVig requested a review from a team June 11, 2020 17:32
Copy link

@emroussel emroussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I don't think create react app supports eslint 7 😕

https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/package.json#L47

Not sure if this change was for fms-ui or another repo, but it does mean that we wouldn't be able to update fms-ui to use this config until they support the next version of eslint

@AdamVig
Copy link
Contributor Author

AdamVig commented Jun 11, 2020

@emroussel That's a great catch! Looks like ESLint 7 support is almost ready, so it wouldn't be long before we could update fms-ui to use the latest version of this configuration: facebook/create-react-app#8978

More broadly, I try to keep the dependencies of this package up to date because it's used by every repository. Currently, this package's peer dependency on ESLint would actually prevent consumers from updating to ESLint 7, which is lame.

I'm comfortable merging this and waiting to update fms-ui until CRA adds support for ESLint 7, since there are plenty of other repositories that could immediately benefit from this update.

@AdamVig AdamVig requested a review from emroussel June 11, 2020 18:27
@AdamVig AdamVig merged commit 302c9e2 into master Jun 11, 2020
@AdamVig AdamVig deleted the breaking-updates branch June 11, 2020 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants