Skip to content
This repository has been archived by the owner on Jul 3, 2023. It is now read-only.

[MGDOBR-1152] - Update GH actions to use Node.js 16 and deprecated commands #1228

Merged

Conversation

afalhambra
Copy link
Contributor

MGDOBR-1152

PR owner checklist

Please make sure that your PR meets the following requirements:

  • Your code is properly formatted according to this configuration.
    Run mvn clean verify -DskipTests so that imports are correctly set.
  • Your commit messages are clear and reference the JIRA issue e.g: "[MGDOBR-1] - $clear_explanation_of_what_you_did"
  • The layers in the kustomize folder have been updated accordingly.
  • All new functionality is tested
  • Pull Request title is properly formatted: MGDOBR-XYZ Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket

PR reviewer(s) checklist

  • Check if code and Github action workflows have been modified and if the modification is safe
  • If the modification is safe, add the safe to test label
How to trigger pipelines and use the bots:
  • Run the end to end pipeline
    Annotate the pull request with the label: safe to test. If you want to run the pipeline again, remove and add it again.

  • Rebase the pull request
    Comment with: /rebase.

  • Deploy BOT
    Comment with `/deploy <dev,stable> when the PR has been merged to deploy to a target environment.

@afalhambra
Copy link
Contributor Author

@afalhambra afalhambra force-pushed the MGDOBR-1152_fix branch 2 times, most recently from d828c2b to c54c41b Compare October 18, 2022 17:46
@sutaakar
Copy link
Contributor

@afalhambra I still see some usage of Node 12. Seems to be used by transitive actions.
Can you please revise that? It seems that at least setup-maven-action could be updated to use Node 16 compatible transitive actions.

@afalhambra
Copy link
Contributor Author

@sutaakar - I've updated all the GHA. However, this PR is again blocked by the below pending PRs:

@afalhambra afalhambra force-pushed the MGDOBR-1152_fix branch 2 times, most recently from 7e68c03 to 99677a8 Compare October 19, 2022 18:11
@afalhambra
Copy link
Contributor Author

@sutaakar - I've updated all the GHA. However, this PR is again blocked by the below pending PRs:

Ok, now, only this one is pending to go:

ScaCap/action-surefire-report#93

@sutaakar
Copy link
Contributor

Seems the latest release of action-surefire-report is a year ago.
Maybe it may have sense to find action which is better maintained....

@sutaakar
Copy link
Contributor

Makes me think, do we really need this action? Is anybody using the Surefire summary from CI summary page?
IMHO it doesn't seem to bring much benefit.

@sutaakar
Copy link
Contributor

sutaakar commented Oct 20, 2022

Seems that we also need stCarolas/setup-maven#28, because of transitive dependency

@afalhambra afalhambra changed the title [MGDOBR-1152] - Update GH actions to use Node.js 16 [MGDOBR-1152] - Update GH actions to use Node.js 16 and deprecated commands Oct 20, 2022
@jiripetrlik
Copy link
Contributor

@afalhambra
Can we remove "on hold" label?

@afalhambra afalhambra merged commit c2cf74d into 5733d9e2be6485d52ffa08870cabdee0:main Nov 2, 2022
@r00ta r00ta mentioned this pull request Nov 3, 2022
11 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants