Bump cypress peer dependency to accept 3.x, 4.x, and 5.x #42
Conversation
package.json
Outdated
| @@ -44,6 +44,6 @@ | |||
| }, | |||
| "dependencies": {}, | |||
| "peerDependencies": { | |||
| "cypress": "^3.1.0" | |||
| "cypress": "^2.1.0 || ^3.1.0 || ^4.0.0 || ^5.0.0" | |||
There was a problem hiding this comment.
What about using "cypress": "*" ?
There was a problem hiding this comment.
Could be!
The only caveat I see on using * is that what if cypress 6 comes along with a major breaking change? I know it's not a real concern today, but I think it's nice for a library to keep the dependencies list with only known working deps. That way, when cypress 6 comes out (or something like that), you or the core contributors can manually approve that this package is still compatible with the new version, and publish a new version...
But I can change if you want me to, no problem!
|
@Sauloxd Could you please rebase against master. I updated all devDependencies and let the tests run against cypress 6.x. So https://github.com/4teamwork/cypress-drag-drop/pull/42/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R32 is obsolete them. |
Sauloxd
force-pushed
the
bump-cypress-5
branch
from
87302b1
to
52025db
Compare
Hi there!
We are having a little problem when bumping to cypress 5, related to multiple cypress versions being installed together, and I think that's due to the multiple versions of cypress being defined in our yarn.lock.
Related issue: