Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge rust-bitcoin#2565: Removes txid prefix in transaction IDs
56132f5 Remove the `:#` formatting for `hex_fmt_impl` macro (448 OG) Pull request description: This commit attempts to solve rust-bitcoin#2505 by ensuring that formatting is not forced using the `:#` in the hex macro code generating in macro rule `hex_fmt_impl` in the hashes/utils.rs file. The write! macro forces all formatting to add the prefix `0x` by adding an alternate by (#) default ```rust impl<$($gen: $gent),*> $crate::_export::_core::fmt::Debug for $ty<$($gen),*> { #[inline] fn fmt(&self, f: &mut $crate::_export::_core::fmt::Formatter) -> $crate::_export::_core::fmt::Result { write!(f, "{:#}", self) // <-- This is where the formatting is being forced. } } ``` By removing this formatting, the `:#` must be specified by the user in order for a prefix to be added. ```rust let outpoint = bitcoin::OutPoint::default(); println!("{:?}", &outpoint); println!("{:#?}", &outpoint); println!("{:#}", &outpoint); println!("{:x}", &outpoint.txid); // `{:#}` must be specified to pretty print with a prefix println!("{:#}", &outpoint.txid); dbg!(&outpoint); dbg!(&outpoint.txid); ``` The PR also adds testcase for this when running `cargo test` . ACKs for top commit: tcharding: ACK 56132f5 apoelstra: ACK 56132f5 Tree-SHA512: 9e4fc9f30ab0b3cf2651d3c09f7f01d8245ac8ea7ae3a82bb4efd19f25c77662bf279020a31fa61b37587cc0c74284696c56045c59f1ba63b2dd42a210d98ebc
- Loading branch information