Remove duplicated Quick start images #3729
Conversation
|
What's the issue and how removing these images help to solve it? |
|
@jlledom actually this duplicated images is not the cause of the problem, but they're duplicated anyway and we should remove them. Regarding the problem, I'm working on a fix so, if it works, I'll rewrite the PR according to that. |
|
Why do we need to copy the images to |
| @@ -64,10 +64,10 @@ | |||
| "@types/lodash.escaperegexp": "^4.1.7", | |||
There was a problem hiding this comment.
Better not to add too many unrelated changes or they will make a mess of git's history.
|
This PR is stale because it has not received activity for more than 30 days. Remove stale label or comment or this will be closed in 15 days. |
|
What's the problem? How can I reproduce it and check if it's fixed? |
The images are not shown in quickstarts (those that have images) in production mode:
|
There was a problem hiding this comment.
This is not related to the PR
| // Handle images coming from the assets folder | ||
| environment.plugins.append('Copy', new CopyWebpackPlugin({ | ||
| patterns: [ | ||
| { from: 'app/assets/images', to: 'images' } | ||
| ] | ||
| })); | ||
|
|
There was a problem hiding this comment.
Doesn't this duplicate the images again?
Instead of copying, is there a way to tell webpack to map images/ to assets/images/, and avoid the copy?
|
Forgot to mention: I tried this branch locally and the error is fixed for me. |
What this PR does / why we need it:
Remove duplicated Quick start images that could potentially be causing an issue with assets handling.