Update webpacker to 5.4.3 #3085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not stale, it's waiting for #3054 to be merged first |
# Conflicts: # package.json # yarn.lock
jlledom
force-pushed
the
revert-3084-revert_webpacker_5
branch
from
d250bc5
to
3a58b22
Compare
|
I merged the new typescript base code |
|
Closing in favor of #3199 |
|
Let's merge this @jlledom |
josemigallas
previously approved these changes
Feb 17, 2023
|
After migration, no?? |
|
we can merge it but not deploy it until after migrating, legacy won't accept this |
|
Then as we agreed, we wont merge things that legacy will not accept before we get rid of it. |
akostadinov
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required to merge #3072