New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Threescale 7522] Fix CDN urls for fonts assets #3072
Commits on Oct 6, 2022
-
-
-
THREESCALE-7522: Decouple CDN url from assets compilation
The CDN url must be hardcoded at settings.yml:asset_host during assets compilation in order to get static assets like CSS files point to the CDN. Otherwise, the assets are generated with relative paths and are not loaded from the CDN, even when settings.yml:asset_host is set during runtime. We don't want to have to provide any CDN url when building porta docker images in order to get the assets correctly precompiled. To avoid that, this trick assumes the assets are generated with relative paths (settings.yml:asset_host = null during compilation time) and prepends the CDN url in runtime. By default, settings.yml:asset_host is set to RAILS_ASSET_HOST, which makes this env variable the only source of truth for CDN urls.
Commits on Oct 11, 2022
-
Folllorw Red Hat style guidelines on environment.js
Co-authored-by: Aleksandar N. Kostadinov <akostadinov@gmail.com>
Commits on Oct 13, 2022
Commits on Oct 18, 2022
Commits on Oct 20, 2022
-
THREESCALE-7522: Remove exception for SaaS
We're not going to merge until SaaS is moved to OCP
Commits on Oct 21, 2022
-
THREESCALE-7522: Prevent compiling assets w/ asset host
In order to be able to load both Sprockets and Webpacker assets from a CDN, the asset host property must be empty during the webpack assets compilation time. This ensures urls are generated as relative paths and webpack can safely prepend the CDN url to them.
Commits on Oct 24, 2022
-
Revert "THREESCALE-7522: Update webpacker to 5.4.3"
This reverts commit 2c3e4a8