Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Threescale 7522] Fix CDN urls for fonts assets #3072

Closed
wants to merge 17 commits into from

Commits on Oct 6, 2022

  1. Copy the full SHA
    2c3e4a8 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    e0010c3 View commit details
    Browse the repository at this point in the history
  3. THREESCALE-7522: Decouple CDN url from assets compilation

    The CDN url must be hardcoded at settings.yml:asset_host during assets
    compilation in order to get static assets like CSS files point to the
    CDN. Otherwise, the assets are generated with relative paths and are
    not loaded from the CDN, even when settings.yml:asset_host is set during
    runtime. We don't want to have to provide any CDN url when building
    porta docker images in order to get the assets correctly precompiled.
    To avoid that, this trick assumes the assets are generated with relative
    paths (settings.yml:asset_host = null during compilation time) and
    prepends the CDN url in runtime.
    
    By default, settings.yml:asset_host is set to RAILS_ASSET_HOST, which
    makes this env variable the only source of truth for CDN urls.
    jlledom committed Oct 6, 2022
    Copy the full SHA
    295a331 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. Folllorw Red Hat style guidelines on environment.js

    Co-authored-by: Aleksandar N. Kostadinov <akostadinov@gmail.com>
    jlledom and akostadinov committed Oct 11, 2022
    Copy the full SHA
    6e9c99d View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2022

  1. Copy the full SHA
    f29bb2d View commit details
    Browse the repository at this point in the history
  2. THREESCALE-7522: Remove TODOs

    jlledom committed Oct 13, 2022
    Copy the full SHA
    468c0db View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2022

  1. Copy the full SHA
    44c1e54 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. Copy the full SHA
    19f3fc0 View commit details
    Browse the repository at this point in the history
  2. THREESCALE-7522: Remove exception for SaaS

    We're not going to merge until SaaS is moved to OCP
    jlledom committed Oct 20, 2022
    Copy the full SHA
    401fb66 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2022

  1. THREESCALE-7522: Prevent compiling assets w/ asset host

    In order to be able to load both Sprockets and Webpacker assets from a CDN, the asset host property must be empty during the webpack assets compilation time. This ensures urls are generated as relative paths and webpack can safely prepend the CDN url to them.
    jlledom committed Oct 21, 2022
    Copy the full SHA
    3f9cdf0 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. Revert "THREESCALE-7522: Update webpacker to 5.4.3"

    This reverts commit 2c3e4a8
    jlledom committed Oct 24, 2022
    Copy the full SHA
    9d05346 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2022

  1. Copy the full SHA
    727a33c View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    f67119c View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    13398a2 View commit details
    Browse the repository at this point in the history
  4. Refactor CDN asset host tests

    jlledom committed Dec 19, 2022
    Copy the full SHA
    a9a771f View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    90fb76b View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. Copy the full SHA
    8a79e58 View commit details
    Browse the repository at this point in the history