Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Yarn integrity checks in Development #2512

Merged
merged 1 commit into from Jul 7, 2021

Conversation

josemigallas
Copy link
Contributor

@josemigallas josemigallas commented Jul 5, 2021

What this PR does / why we need it:

Yarn's integrity checks detect unsatisfied or missing NPM dependencies. The problem is some of the error might be inevitable since are thrown by dependencies of a dependency and it's really annoying to get this error "out of nowhere" and block certain commands like bundle or the assets:compile.

error Couldn't find an integrity file                                                                                                                                                           
error Found 1 errors.
                                                                                                                                                                           
========================================
  Your Yarn packages are out of date!
  Please run `yarn install --check-files` to update.
========================================

To disable this check, please change `check_yarn_integrity`
to `false` in your webpacker config file (config/webpacker.yml).

yarn check v1.22.4
info Visit https://yarnpkg.com/en/docs/cli/check for documentation about this command.

Verification steps

Hard to say but I'm sure everyone has seen this, specially @3scale/system-ux .

Webpacker has officially removed yarn integrity since v5, and they recommend to disable it if causing problems.
See PR
And issues rails/webpacker#2354, rails/webpacker#2517
We are still using v4, but I think we can remove it.
WDYT @didierofrivia @hallelujah ?

@josemigallas josemigallas requested a review from a team July 5, 2021 08:56
@hallelujah
Copy link
Contributor

I always overcome it by removing node_modules and do yarn install:safe

@didierofrivia what do you think about this?

@josemigallas
Copy link
Contributor Author

I always overcome it by removing node_modules and do yarn install:safe

@didierofrivia what do you think about this?

I usually am able to work around it as well but it's become super annoying lately and the only solution that works for me is disabling it.

@hallelujah hallelujah merged commit 7169792 into master Jul 7, 2021
@hallelujah hallelujah deleted the disable_integrity_check_dev branch July 7, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants