feat(#635): Support isExpanded on KtDrawer
#641
+76
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://kotti-pr-641.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-caq83hvs437gvhlcqe6g. |
carsoli
added
type:enhancement
carsoli
force-pushed
the
635-support-is-expanded-on-kt-drawer
branch
from
09cb5de
to
b20fff7
Compare
FlorianWendelborn
force-pushed
the
635-support-is-expanded-on-kt-drawer
branch
6 times, most recently
from
88765af
to
015da93
Compare
santiagoballadares
previously approved these changes
Jun 27, 2022
FlorianWendelborn
force-pushed
the
635-support-is-expanded-on-kt-drawer
branch
from
015da93
to
cf976e5
Compare
carsoli
force-pushed
the
635-support-is-expanded-on-kt-drawer
branch
from
cf976e5
to
015da93
Compare
FlorianWendelborn
force-pushed
the
635-support-is-expanded-on-kt-drawer
branch
3 times, most recently
from
cb1c39d
to
b9ad6d9
Compare
FlorianWendelborn
added
the
autorebase:non-rebaseable
FlorianWendelborn
requested changes
Jun 28, 2022
| @@ -12,6 +12,7 @@ | |||
| // Utility classes | |||
| @import 'utilities'; | |||
| @import 'media'; | |||
| @import 'mixins'; | |||
There was a problem hiding this comment.
Not 100% sure, but this looks like a no-op.
There was a problem hiding this comment.
i moved it under kotti-style, so
There was a problem hiding this comment.
@FlorianWendelborn can this be resolved?
There was a problem hiding this comment.
Still seems like a noop
There was a problem hiding this comment.
can you either elaborate on why you think it is or test it?
carsoli
changed the title
isExpanded on KtDrawerisExpanded on KtDrawer
carsoli
force-pushed
the
635-support-is-expanded-on-kt-drawer
branch
from
b9ad6d9
to
3dcd403
Compare
FlorianWendelborn
removed
the
autorebase:non-rebaseable
santiagoballadares
previously approved these changes
Jul 25, 2022
FlorianWendelborn
force-pushed
the
635-support-is-expanded-on-kt-drawer
branch
5 times, most recently
from
1178f95
to
bc552ab
Compare
FlorianWendelborn
force-pushed
the
635-support-is-expanded-on-kt-drawer
branch
5 times, most recently
from
41bfafa
to
18c0352
Compare
FlorianWendelborn
force-pushed
the
635-support-is-expanded-on-kt-drawer
branch
3 times, most recently
from
86d32b9
to
8a79034
Compare
FlorianWendelborn
force-pushed
the
635-support-is-expanded-on-kt-drawer
branch
from
8a79034
to
2285841
Compare
FlorianWendelborn
force-pushed
the
635-support-is-expanded-on-kt-drawer
branch
2 times, most recently
from
c075a6c
to
ca86592
Compare
carsoli
changed the title
isExpanded on KtDrawerisExpanded on KtDrawer
used by more than just the kotti-fields now
use variables for transitions
carsoli
force-pushed
the
635-support-is-expanded-on-kt-drawer
branch
from
ca86592
to
7adaca5
Compare
FlorianWendelborn
added
the
autorebase:non-rebaseable
Isokaeder
force-pushed
the
master
branch
6 times, most recently
from
db0f2aa
to
78dbab4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.