Refactor kotti pagination

[Isokaeder]

The usual shtick, some typescript, some zod, some rearranging of code and whatnot

[render]

Your Render PR Server URL is https://kotti-pr-543.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c5jpedc6fj36arvjfvkg.

[carsoli]

removed totalPages from object

added adjacentAmount

[carsoli]

why not

PagingStyle.FLEX

& for the next case PagingStyle.FRACTION

[carsoli]

you want to fallback to the default case if a certain condition is not met

so IMO

case 'flex': { if(isFlexLogical && pageAmount.value >=2) return PaginationFlexible.name }
case 'fraction': return PaginationFractionated.name
case 'expanded': 
default: return PaginationExpanded.name

[carsoli]

returning always breaks out of the switch

but since we don't return, the switch will continue to the next plausible cases (not going to match fraction/expanded but will match default)

[carsoli]

don't know if you see the bug (already there before ur refactor :D)

but

you first update the currentPage.value then you emit currentPage + 1

if currentPage was 0 before this function got clicked

you'd emit 2

I suggested line 68 becomes

emit('nextPageClicked', currentPage.value)

or you make it ridiculously verbose

const nextPage = currentPage.value+1
currentPage.value = nextPage
emit('nextPageClicked', nextPage)

[carsoli]

ok now that i've seen the entire code, my guess is: currentPage is zero-based and page is one-based and we were circumventing this internally like this

honestly, would rather this whole issue is solved differently

instead of this weirdness, might as well start currentPage with this

also I'd say we can make page prop in types.ts use zod.number().min(1)

this will error if user app passes anything less than 1

[carsoli]

so the bug here is that we counteract the -1

so we are emitting the old page

[carsoli]

we seem to counteract it in some places in our user app

some usage example: @previousPageClicked="setPage(pageIndex-1)"

[carsoli]

if you fix the logic for the currentPage being zero-based while the page prop is one-based

don't forget to change this as well
(you'd have to pass 1 and maximumPage+1 which would be pageAmount)

[carsoli]

if you change currentPage to be one-paged, don't forget this argument as well (would have to be 1-based