Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add-zod(5): Add makeProps #504

Merged
merged 16 commits into from
Sep 24, 2021
Merged

add-zod(5): Add makeProps #504

merged 16 commits into from
Sep 24, 2021

Commits on Sep 22, 2021

  1. refactor(#285): Add zod 

    Also, this adds a surplus check so that jest sees that result.error is defined

This isn’t necessary for TS itself, but somehow ts-jest didn’t see this... upgrading to latest didn’t fix this bug unfortunately, so this is as good as it gets
    @FlorianWendelborn @carsoli
    FlorianWendelborn authored and carsoli committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    019479f View commit details
    Browse the repository at this point in the history

  2. refactor(#285): Add zod for KtUserMenu

    @FlorianWendelborn @carsoli
    FlorianWendelborn authored and carsoli committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    c9c44ad View commit details
    Browse the repository at this point in the history

  3. refactor(#285): Add zod for KtNavbar

    @FlorianWendelborn @carsoli
    FlorianWendelborn authored and carsoli committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    257ea96 View commit details
    Browse the repository at this point in the history

  4. refactor(#285): Add zod for KtButton

    @FlorianWendelborn @carsoli
    FlorianWendelborn authored and carsoli committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    4fd7ece View commit details
    Browse the repository at this point in the history

  5. refactor(#285): Add zod for KtBreadcrumb

    @FlorianWendelborn @carsoli
    FlorianWendelborn authored and carsoli committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    758467e View commit details
    Browse the repository at this point in the history

  6. refactor(#285): Add zod for KtBanner

    @FlorianWendelborn @carsoli
    FlorianWendelborn authored and carsoli committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    8bed26f View commit details
    Browse the repository at this point in the history

  7. refactor(#285): Add zod for KtLine

    @FlorianWendelborn @carsoli
    FlorianWendelborn authored and carsoli committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    930eb2b View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2021

  1. refactor(#285): propValidator => makeProps 

    Unfortunately, the makeProps type hints only work for some types in Vue, others somehow get resolved to any. As far as I can tell, this is due to PropType<> being buggy.

I also tested @vue/composition-api@1.1.5 and PropType does appear to be broken there as well.

Let’s hope that one day Vue will properly support this.
    @FlorianWendelborn
    FlorianWendelborn committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    37d0a51 View commit details
    Browse the repository at this point in the history

  2. tests(#285): Add Unit Tests for makeProps

    @FlorianWendelborn
    FlorianWendelborn committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    62670f1 View commit details
    Browse the repository at this point in the history

  3. refactor(#285): Replace While with Switch in walkSchemaTypes, Address… 

    … Various PR Comments

Co-Authored-By: Carol Soliman <17387510+carsoli@users.noreply.github.com>
    @FlorianWendelborn @carsoli
    FlorianWendelborn and carsoli committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    29217ca View commit details
    Browse the repository at this point in the history

  4. refactor(#285): props.ts -> make-props.ts 

    Co-Authored-By: Carol Soliman <17387510+carsoli@users.noreply.github.com>
    @FlorianWendelborn @carsoli
    FlorianWendelborn and carsoli committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    1e70461 View commit details
    Browse the repository at this point in the history

  5. refactor(#285): Rename DEBUG_WALK_SHAPE to match function name 

    Co-Authored-By: Carol Soliman <17387510+carsoli@users.noreply.github.com>
    @FlorianWendelborn @carsoli
    FlorianWendelborn and carsoli committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    4e21270 View commit details
    Browse the repository at this point in the history

  6. refactor(#285): Improve Test Readability via expect.extend & SUCCESS/… 

    …FAILURE Arrays
    @FlorianWendelborn
    FlorianWendelborn committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    1ce7ea7 View commit details
    Browse the repository at this point in the history

  7. refactor(#285): Englishify Tests 

    Co-Authored-By: Carol Soliman <17387510+carsoli@users.noreply.github.com>
    @FlorianWendelborn @carsoli
    FlorianWendelborn and carsoli committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    9a7a632 View commit details
    Browse the repository at this point in the history

  8. test(#285): Add Tests for z.number().int()

    @FlorianWendelborn
    FlorianWendelborn committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    ab95b50 View commit details
    Browse the repository at this point in the history

  9. chore(#285): Replace .nonempty with .refine(...refinementNonEmpty) 

    z.array().nonempty() influences the type definitions, and causes issues with Array.prototype.map() not being aware of the underlying array's cardinality.
    @FlorianWendelborn
    FlorianWendelborn committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    d283c56 View commit details
    Browse the repository at this point in the history