feature(#285): Add Zod to Massively Improve Validation #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorianWendelborn
added
type:enhancement
|
Your Render PR Server URL is https://kotti-pr-494.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c4rrqhcobjddd9dd0svg. |
FlorianWendelborn
force-pushed
the
add-zod
branch
2 times, most recently
from
6ec4813
to
855e578
Compare
FlorianWendelborn
force-pushed
the
add-zod
branch
from
855e578
to
081448d
Compare
FlorianWendelborn
force-pushed
the
add-zod
branch
3 times, most recently
from
fb60c3f
to
6c952c6
Compare
|
lgtm so far. Not all components got a redo, but we can do that incrementally. Approved |
Isokaeder
previously approved these changes
Sep 9, 2021
Isokaeder
reviewed
Sep 12, 2021
FlorianWendelborn
force-pushed
the
add-zod
branch
10 times, most recently
from
3197c8b
to
7bf234a
Compare
FlorianWendelborn
changed the title
FlorianWendelborn
force-pushed
the
add-zod
branch
from
3309c23
to
7d06d7e
Compare
TS 4.4.2 is unfortunately not possible yet, as there’s this rollup+typescript bug that will most likely be fixed in TS 4.4.3: rollup/plugins#983 microsoft/TypeScript#45633
Previously, the upgrade to 4.3 made the pipelines fail. This should hopefully now be fixed. Co-Authored-By: Moritz Vetter <16950410+HansAuger@users.noreply.github.com>
…Defined This isn’t necessary for TS itself, but somehow ts-jest didn’t see this... upgrading to latest didn’t fix this bug unfortunately, so this is as good as it gets
Unfortunately, while this works for some types in Vue, this resolves some others to any. As far as I can tell, this is due to PropType<> being buggy. I also tested @vue/composition-api@1.1.5 and PropType does appear to be broken there as well. Let’s hope that one day Vue will properly support this.
github-actions
bot
force-pushed
the
add-zod
branch
from
7d06d7e
to
c46835a
Compare
FlorianWendelborn
added
the
autorebase:opt-in
FlorianWendelborn
force-pushed
the
add-zod
branch
from
c46835a
to
37b015d
Compare
Isokaeder
dismissed
their stale review
Since there are a bunch of changes since my review I dismiss my last one. Please mark MR as draft
FlorianWendelborn
force-pushed
the
add-zod
branch
4 times, most recently
from
b1fd8c4
to
abd60f8
Compare
|
@HansAuger Well, it’s not really a draft, it’s just that I found some ways to improve it while I’m waiting for @carsoli’s review :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #285
Split to multiple PRs. See #504