Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Prop Validation EVERYWHERE #285

Closed
3 tasks done
FlorianWendelborn opened this issue Sep 11, 2020 · 0 comments · Fixed by #504, #505, #506, #507 or #508
Closed
3 tasks done

Add Prop Validation EVERYWHERE #285

FlorianWendelborn opened this issue Sep 11, 2020 · 0 comments · Fixed by #504, #505, #506, #507 or #508
Assignees
@FlorianWendelborn
Labels
package:kotti-ui @3yourmind/kotti-ui priority:4-high ⚠️ Needs to be fixed ASAP, but without HACKs state:help wanted type:enhancement features, etc.

Comments

@FlorianWendelborn
Copy link
Member

FlorianWendelborn commented Sep 11, 2020 •
edited

Just saw a KtCol span="2.5". We absolutely need validators for everything.

  • Validate Numbers to be Integers if Required
  • Validate With Whitelists
  • Validate Yoco Icons

I think at this point it makes sense to create a @3yourmind/vue-validators package or similar.

This will now use zod
@FlorianWendelborn FlorianWendelborn added type:enhancement features, etc. state:help wanted priority:4-high ⚠️ Needs to be fixed ASAP, but without HACKs package:kotti-ui @3yourmind/kotti-ui labels Sep 11, 2020
@FlorianWendelborn FlorianWendelborn self-assigned this Sep 11, 2020
FlorianWendelborn added a commit that referenced this issue Sep 13, 2020
@FlorianWendelborn
feature(#285): Basic Implementation of Vue Props Validators
1d991ca
@FlorianWendelborn FlorianWendelborn linked a pull request Sep 13, 2020 that will close this issue
feature(#285): Basic Implementation of Vue Props Validators #287
Closed
FlorianWendelborn added a commit that referenced this issue Sep 13, 2020
@FlorianWendelborn
feature(#285): Implement More Types, Refactor, Test in KtCol
cddf94f
FlorianWendelborn added a commit that referenced this issue Sep 13, 2020
@FlorianWendelborn
feature(#285): Basic Implementation of Vue Props Validators
a8b04f5
FlorianWendelborn added a commit that referenced this issue Sep 13, 2020
@FlorianWendelborn
feature(#285): Implement More Types, Refactor, Test in KtCol
eec3cad
FlorianWendelborn added a commit that referenced this issue Sep 13, 2020
@FlorianWendelborn
documentation(#285): Update Readme
555b285
FlorianWendelborn added a commit that referenced this issue Sep 13, 2020
@FlorianWendelborn
feature(#285): Add maximum/minimum Validators to Type.FLOAT & Type.IN…
35cba51 
…TEGER
FlorianWendelborn added a commit that referenced this issue Sep 13, 2020
@FlorianWendelborn
feature(#285): Add Type.BOOLEAN
a8ff817
FlorianWendelborn added a commit that referenced this issue Sep 13, 2020
@FlorianWendelborn
refactor(#285): KtButton to @vue/composition-api
a6788d8
@FlorianWendelborn FlorianWendelborn pinned this issue Sep 15, 2020
FlorianWendelborn added a commit that referenced this issue Sep 18, 2020
@FlorianWendelborn
fix(#285): Ignore Dist Folder in Jest
533bb06
FlorianWendelborn added a commit that referenced this issue Sep 21, 2020
@FlorianWendelborn
feature(#285): Basic Implementation of Vue Props Validators
41daabf
FlorianWendelborn added a commit that referenced this issue Sep 21, 2020
@FlorianWendelborn
feature(#285): Implement More Types, Refactor, Test in KtCol
a7fae3a
FlorianWendelborn added a commit that referenced this issue Sep 21, 2020
@FlorianWendelborn
documentation(#285): Update Readme
d64cbaf
FlorianWendelborn added a commit that referenced this issue Sep 21, 2020
@FlorianWendelborn
feature(#285): Add maximum/minimum Validators to Type.FLOAT & Type.IN…
3a58c7b 
…TEGER
FlorianWendelborn added a commit that referenced this issue Sep 21, 2020
@FlorianWendelborn
feature(#285): Add Type.BOOLEAN
57b5fb0
FlorianWendelborn added a commit that referenced this issue Sep 21, 2020
@FlorianWendelborn
refactor(#285): KtButton to @vue/composition-api
20b56e3
FlorianWendelborn added a commit that referenced this issue Sep 21, 2020
@FlorianWendelborn
fix(#285): Ignore Dist Folder in Jest
af6f9b7
FlorianWendelborn added a commit that referenced this issue Sep 21, 2020
@FlorianWendelborn
feature(#285): Basic Implementation of Vue Props Validators
657da63
FlorianWendelborn added a commit that referenced this issue Sep 21, 2020
@FlorianWendelborn
feature(#285): Implement More Types, Refactor, Test in KtCol
9b625ea
FlorianWendelborn added a commit that referenced this issue Sep 21, 2020
@FlorianWendelborn
documentation(#285): Update Readme
ca09f1a
FlorianWendelborn added a commit that referenced this issue Sep 21, 2020
@FlorianWendelborn
feature(#285): Add maximum/minimum Validators to Type.FLOAT & Type.IN…
208569b 
…TEGER
FlorianWendelborn added a commit that referenced this issue Sep 21, 2020
@FlorianWendelborn
feature(#285): Add Type.BOOLEAN
5da96f6
FlorianWendelborn added a commit that referenced this issue Sep 21, 2020
@FlorianWendelborn
refactor(#285): KtButton to @vue/composition-api
202612f
FlorianWendelborn added a commit that referenced this issue Sep 21, 2020
@FlorianWendelborn
fix(#285): Ignore Dist Folder in Jest
189e1ff
FlorianWendelborn added a commit that referenced this issue Sep 21, 2021
@FlorianWendelborn
refactor(#285): Add zod for KtNavbar
33295fb
FlorianWendelborn added a commit that referenced this issue Sep 21, 2021
@FlorianWendelborn
refactor(#285): Add zod for KtButton
aa8f7ac
FlorianWendelborn added a commit that referenced this issue Sep 21, 2021
@FlorianWendelborn
refactor(#285): Add zod for KtBreadcrumb
40343f3
FlorianWendelborn added a commit that referenced this issue Sep 21, 2021
@FlorianWendelborn
refactor(#285): Add zod for KtBanner
58e6085
FlorianWendelborn added a commit that referenced this issue Sep 21, 2021
@FlorianWendelborn
refactor(#285): Add zod for KtLine
5963a46
carsoli pushed a commit that referenced this issue Sep 22, 2021
@FlorianWendelborn @carsoli
refactor(#285): Add zod
019479f 
Also, this adds a surplus check so that jest sees that result.error is defined

This isn’t necessary for TS itself, but somehow ts-jest didn’t see this... upgrading to latest didn’t fix this bug unfortunately, so this is as good as it gets
carsoli pushed a commit that referenced this issue Sep 22, 2021
@FlorianWendelborn @carsoli
refactor(#285): Add zod for KtUserMenu
c9c44ad
carsoli pushed a commit that referenced this issue Sep 22, 2021
@FlorianWendelborn @carsoli
refactor(#285): Add zod for KtNavbar
257ea96
carsoli pushed a commit that referenced this issue Sep 22, 2021
@FlorianWendelborn @carsoli
refactor(#285): Add zod for KtButton
4fd7ece
carsoli pushed a commit that referenced this issue Sep 22, 2021
@FlorianWendelborn @carsoli
refactor(#285): Add zod for KtBreadcrumb
758467e
carsoli pushed a commit that referenced this issue Sep 22, 2021
@FlorianWendelborn @carsoli
refactor(#285): Add zod for KtBanner
8bed26f
carsoli pushed a commit that referenced this issue Sep 22, 2021
@FlorianWendelborn @carsoli
refactor(#285): Add zod for KtLine
930eb2b
FlorianWendelborn added a commit that referenced this issue Sep 24, 2021
@FlorianWendelborn
refactor(#285): propValidator => makeProps
37d0a51 
Unfortunately, the makeProps type hints only work for some types in Vue, others somehow get resolved to any. As far as I can tell, this is due to PropType<> being buggy.

I also tested @vue/composition-api@1.1.5 and PropType does appear to be broken there as well.

Let’s hope that one day Vue will properly support this.
FlorianWendelborn added a commit that referenced this issue Sep 24, 2021
@FlorianWendelborn
tests(#285): Add Unit Tests for makeProps
62670f1
FlorianWendelborn added a commit that referenced this issue Sep 24, 2021
@FlorianWendelborn @carsoli
refactor(#285): Replace While with Switch in walkSchemaTypes, Address…
29217ca 
… Various PR Comments

Co-Authored-By: Carol Soliman <17387510+carsoli@users.noreply.github.com>
FlorianWendelborn added a commit that referenced this issue Sep 24, 2021
@FlorianWendelborn @carsoli
refactor(#285): props.ts -> make-props.ts
1e70461 
Co-Authored-By: Carol Soliman <17387510+carsoli@users.noreply.github.com>
FlorianWendelborn added a commit that referenced this issue Sep 24, 2021
@FlorianWendelborn @carsoli
refactor(#285): Rename DEBUG_WALK_SHAPE to match function name
4e21270 
Co-Authored-By: Carol Soliman <17387510+carsoli@users.noreply.github.com>
FlorianWendelborn added a commit that referenced this issue Sep 24, 2021
@FlorianWendelborn
refactor(#285): Improve Test Readability via expect.extend & SUCCESS/…
1ce7ea7 
…FAILURE Arrays
FlorianWendelborn added a commit that referenced this issue Sep 24, 2021
@FlorianWendelborn @carsoli
refactor(#285): Englishify Tests
9a7a632 
Co-Authored-By: Carol Soliman <17387510+carsoli@users.noreply.github.com>
FlorianWendelborn added a commit that referenced this issue Sep 24, 2021
@FlorianWendelborn
test(#285): Add Tests for z.number().int()
ab95b50
FlorianWendelborn added a commit that referenced this issue Sep 24, 2021
@FlorianWendelborn
chore(#285): Replace .nonempty with .refine(...refinementNonEmpty)
d283c56 
z.array().nonempty() influences the type definitions, and causes issues with Array.prototype.map() not being aware of the underlying array's cardinality.
carsoli pushed a commit that referenced this issue Sep 24, 2021
@FlorianWendelborn @carsoli
refactor(#285): Add zod for KtUserMenu
3827607
carsoli pushed a commit that referenced this issue Sep 24, 2021
@FlorianWendelborn @carsoli
refactor(#285): Add zod for KtUserMenu
4b6ec09
This was linked to pull requests Oct 3, 2021
add-zod(5): Add makeProps #504
Merged
add-zod(1): Upgrade TS to 4.3.5 #505
Merged
add-zod(2): Upgrade Babel & Jest #506
Merged
add-zod(3): Improve Documentation Rendering for Functions #507
Merged
add-zod(4): Move isYocoIcon to @3yourmind/yoco, Add yocoSchema #508
Merged
@FlorianWendelborn FlorianWendelborn unpinned this issue Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FlorianWendelborn FlorianWendelborn

Labels
package:kotti-ui @3yourmind/kotti-ui priority:4-high ⚠️ Needs to be fixed ASAP, but without HACKs state:help wanted type:enhancement features, etc.
Projects
None yet
Milestone
No milestone
1 participant
@FlorianWendelborn