Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(layout): setup of navbar and footer #35

Merged
merged 17 commits into from
Apr 2, 2023
Merged

feat(layout): setup of navbar and footer #35

merged 17 commits into from
Apr 2, 2023

Conversation

iiAbady
Copy link
Collaborator

@iiAbady iiAbady commented Mar 29, 2023

What does this pull request do?

This pull request is a feature that adds the main layout components: navbar and footer. Alongside them, are tests.

@iiAbady iiAbady linked an issue Mar 29, 2023 that may be closed by this pull request
[General] Setup main layout #11
Closed
5 tasks
@vercel
Copy link

vercel bot commented Mar 29, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pebblework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2023 2:53am

SufyanCS
SufyanCS reviewed Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@SufyanCS SufyanCS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1- add padding to the logo and the change language icon
aa
2- add responsive design for tablet and mobile
3- Try to break the navbar into smaller components
4- Fix all errors that shows in the console
5- add links path to the sign in/up buttons

@iiAbady
Copy link
Collaborator Author

iiAbady commented Mar 31, 2023

1- add padding to the logo and the change language icon aa 2- add responsive design for tablet and mobile 3- Try to break the navbar into smaller components 4- Fix all errors that shows in the console 5- add links path to the sign in/up buttons

As for the console errors, I'll fix them but there is one console warn related to i18-next that I can't fix. (see: i18next/next-i18next#1917)

@iiAbady iiAbady marked this pull request as ready for review April 1, 2023 14:57
@iiAbady iiAbady self-assigned this Apr 1, 2023
@iiAbady iiAbady added the enhancement New feature or request label Apr 1, 2023
adeeb-samad
adeeb-samad reviewed Apr 1, 2023
View reviewed changes
Copy link
Collaborator

@adeeb-samad adeeb-samad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

sulmi24
sulmi24 requested changes Apr 1, 2023
View reviewed changes
Copy link
Collaborator

@sulmi24 sulmi24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting the pull request.
Overall, this pull request looks good, but I have a few suggestions for improvement:

Please make sure to add sufficient margin and padding to the design for the Logo.
image
The design needs to be made responsive for mobile and tablet devices.
image

Tryalign the social media icons with the page links on the footer.

Keep up the good work!"

@iiAbady
Copy link
Collaborator Author

iiAbady commented Apr 2, 2023

@sulmi24 Did the changes by having better responesivness, I think this is ready to be merged.

HamadBakeel
HamadBakeel approved these changes Apr 2, 2023
View reviewed changes
Copy link
Collaborator

@HamadBakeel HamadBakeel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks better so far and yet to be enhanced in future updated fixes

@iiAbady iiAbady changed the title feat(layout): add navbar with links feat(layout): setup of navbar and footer Apr 2, 2023
adeeb-samad
adeeb-samad approved these changes Apr 2, 2023
View reviewed changes
Copy link
Collaborator

@adeeb-samad adeeb-samad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

adeeb-samad
adeeb-samad approved these changes Apr 2, 2023
View reviewed changes
Copy link
Collaborator

@adeeb-samad adeeb-samad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

sulmi24
sulmi24 approved these changes Apr 2, 2023
View reviewed changes
Copy link
Collaborator

@sulmi24 sulmi24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to go
The PR looks good

@iiAbady iiAbady merged commit 9b548a4 into develop Apr 2, 2023
4 checks passed
@iiAbady iiAbady deleted the 11-general-setup-main-layout branch April 2, 2023 13:10
@iiAbady iiAbady added this to the Sprint 1 milestone Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sulmi24 sulmi24 sulmi24 approved these changes

@HamadBakeel HamadBakeel HamadBakeel approved these changes

@adeeb-samad adeeb-samad adeeb-samad approved these changes

@SufyanCS SufyanCS SufyanCS approved these changes

Assignees

@iiAbady iiAbady

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint 1
Development

Successfully merging this pull request may close these issues.

[General] Setup main layout
5 participants
@iiAbady @sulmi24 @HamadBakeel @adeeb-samad @SufyanCS