streamline TS; prettier via eslint #60
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,3 +2,4 @@ node_modules | |
| .idea | ||
| .DS_Store | ||
| yarn-error.log | ||
| .vscode | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,9 @@ | ||
| module.exports = { | ||
| extends: ['eslint-config-1stdibs-base', './rules/react'].map(require.resolve), | ||
| overrides: [ | ||
| { | ||
| files: ['*.{js,jsx}'], | ||
| extends: ['./rules/flowtype'].map(require.resolve), | ||
| }, | ||
| ], | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,27 @@ | ||
| module.exports = { | ||
| plugins: ['@typescript-eslint/eslint-plugin'], | ||
|
There was a problem hiding this comment. You can't combine this file and the index file? There was a problem hiding this comment. I'll play around with it a bit more. There was a problem hiding this comment. Perhaps I'm simply not up-to-date on how So, the way I worked around that was to create a typescript file and the consumer needs to add an override, ie: module.exports = {
extends: ['eslint-config-1stdibs'],
overrides: [
{
files: ['*.{ts,tsx}'],
extends: ['eslint-config-1stdibs/typescript'].map(require.resolve),
parser: '@typescript-eslint/parser',
parserOptions: {
project: './tsconfig.json',
},
},
],
};There was a problem hiding this comment. The consumers will have one .eslintrc file then? Do you need the |
||
| parser: '@typescript-eslint/parser', // Specifies the ESLint parser | ||
| extends: [ | ||
| 'eslint-config-1stdibs-base', | ||
| 'plugin:@typescript-eslint/recommended', | ||
| 'prettier/@typescript-eslint', // Uses eslint-config-prettier to disable ESLint rules from @typescript-eslint/eslint-plugin that would conflict with prettier | ||
| 'plugin:import/typescript', | ||
| ], | ||
| rules: { | ||
| 'react/prop-types': 'off', | ||
| // note you must disable the base rule as it can report incorrect errors | ||
| camelcase: 'off', | ||
| '@typescript-eslint/camelcase': 'off', | ||
| '@typescript-eslint/explicit-member-accessibility': 'warn', | ||
| '@typescript-eslint/no-explicit-any': 'warn', | ||
| '@typescript-eslint/prefer-interface': 'off', | ||
| '@typescript-eslint/explicit-function-return-type': [ | ||
| 'error', | ||
| { | ||
| allowExpressions: true, | ||
| allowTypedFunctionExpressions: true, | ||
| }, | ||
| ], | ||
| '@typescript-eslint/indent': 'off', | ||
| }, | ||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is marked as a dev/peerDep in the individual packages. You'll need to update those references as well.