Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI actions #125

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Update CI actions #125

merged 1 commit into from
Jan 2, 2024

Conversation

robjtede
Copy link
Contributor

  • actions-rs is deprecated / abandoned, replaced with actions-rust-lang/setup-rust-toolchain which is actively maintained and has built-in caching
  • checkout action -> v4

@complexspaces
Copy link
Collaborator

Hey there, thanks for the PR. Do you know anything about the ownership/provenance of actions-rust-lang? Over in rustls, it was migrated to dtolnay/rust-toolchain instead.

@robjtede
Copy link
Contributor Author

robjtede commented Dec 29, 2023

Do you know anything about the ownership/provenance of actions-rust-lang?

Yes, I'm part of that organisation. The primary maintainer @jonasbb also runs some other succesful crates.

As such, I've converted all my and Actix crates over to it where the auto caching and sensible defaults is extra appreciated.

Copy link
Collaborator

@complexspaces complexspaces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification. This looks good to me then.

@complexspaces complexspaces merged commit a648570 into 1Password:master Jan 2, 2024
10 checks passed
@robjtede robjtede deleted the ci-upd branch January 2, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants