Remove unused CSS utility classes #5401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why**: - Moves us toward design system utilities, removing temptation of use for developers and facilitating future substitution work. - Reduces size of stylesheets, producing smaller bundle sizes for users (faster page loads) and lower mental overhead for developers.
aduth
commented
Sep 14, 2021
| .sm-mtn3 { margin-top: -$space-3; } | ||
| } | ||
|
|
||
| .margin-top-neg-4 { |
There was a problem hiding this comment.
Some of these design-system extensions are still in use, but they've been made available directly through newer releases of USWDS.
https://github.com/uswds/uswds/releases/tag/v2.12.0
Added more negative margin tokens to margin utilities. Now you can use utilities like
margin-neg-4andmargin-neg-5. (uswds/uswds#4212)
See source: https://unpkg.com/uswds@2.12.1/dist/css/uswds.css
We inherit USWDS 2.12.1 as of #5383.
mitchellhenke
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: